[OU-ADD] l10n_it remove safely xmlids #5098
Conversation
|
AFAIK this would be |
sergiocorato
changed the title
|
And create |
sergiocorato
force-pushed
the
15.0-fix-l10n_it-migration
branch
2 times, most recently
from
e6f6d5f to
3944e34
Compare
|
sergiocorato
force-pushed
the
15.0-fix-l10n_it-migration
branch
2 times, most recently
from
739c9c6 to
f7a80db
Compare
| NEW account.account.tag: l10n_it.account_tag_E_PL | ||
| NEW account.account.tag: l10n_it.account_tag_IMPEGNI | ||
| NEW account.account.tag: l10n_it.account_tag_RISCHI | ||
| # DONE Deleted safely |
There was a problem hiding this comment.
Put here # nothing to do, as it references the NEW ones. The # DONE Deleted safely should go below the DEL ones.
There was a problem hiding this comment.
@MiquelRForgeFlow this is for not deleting them if they are used. That's why the method is called safely.
There was a problem hiding this comment.
Still, the message "done" should go below the DEL lines.
| "l10n_it.tax_group_iva_22_inde", | ||
| "l10n_it.tax_group_iva_4_de_50", | ||
| ] | ||
| openupgrade.delete_records_safely_by_xml_id(env, to_delete_xml_ids) |
There was a problem hiding this comment.
Also, why delete them? Cannot ORM handle it? They are not noupdate records.
There was a problem hiding this comment.
Also, why in pre-migration (instead of post-migration)?
sergiocorato
force-pushed
the
15.0-fix-l10n_it-migration
branch
from
f7a80db to
39d71c5
Compare
Remove safely xmlids as they are deleted:
OpenUpgrade/openupgrade_scripts/scripts/l10n_it/15.0.0.3/upgrade_analysis.txt
Line 22 in 584b7c3