Skip to content

[18.0][OU-ADD] hr_attendance_autoclose: Merged into hr_attendance #5127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 18.0
Choose a base branch
from

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Jun 27, 2025

Merged into hr_attendance (Related to OCA/hr-attendance#201 + OCA/hr-attendance#225)

Changes done:

  • hr_attendance: Migration scripts to properly set the auto_check_out + auto_check_out_tolerance value fields.
  • hr_attendance: Set the attendances that have defined the auto-close reasons with out_mode='auto_check_out'
  • hr_attendance_reason: Add functionality to be able to define a reason to be set at auto check-out (similar to hr_attendance_autoclose).

Locked by:

Please @pedrobaeza can you review it?

@Tecnativa TT55521

@victoralmau victoralmau force-pushed the 18.0-mig-hr_attendance_autoclose branch from 15b23d5 to 572f6bf Compare June 27, 2025 14:25
@victoralmau
Copy link
Member Author

Although initially I thought it was necessary to add in hr_attendance_reason the auto-close reason, IMO it is not necessary. The reason is simple, now the out_mode field allows to indicate different options, among them auto_check_out (that option is now defined with hr_attendance in the cron https://github.com/odoo/odoo/blob/1dfa4cc9d259b4918424a07394938e24da8c643d/addons/hr_attendance/models/hr_attendance.py#L726).

@victoralmau victoralmau marked this pull request as ready for review June 27, 2025 14:39
@pedrobaeza pedrobaeza added this to the 18.0 milestone Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants