[16.0][IMP] account_financial_report: Several improvements #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apineux
approved these changes
Nov 7, 2023
|
This PR has the |
If you open a filter tab, you cannot identify the field position. So, display the label in front of it.
On account.move.line, don't store here the analytic accounts as it can be bulky (especially the init on big database).
rousseldenis
force-pushed
the
16.0-imp-account-financial-report-dro
branch
from
441b82d to
c6c4dac
Compare
|
@yajo Nevertheless your comment #1105 (comment), this should be addressed in a better elegant solution than adding a field here. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Aren't now a native analytic search included in core? |
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to trigger a discussion on how to cover the filtering on analytic accounts without storing the analytic accounts on move lines.