Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][IMP] account_financial_report: Add grouping by analytical account in Trial balance #1243

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[16.0][IMP] account_financial_report: Add grouping by analytical account in Trial balance #1243

merged 2 commits into from
Nov 26, 2024

Conversation

victoralmau
Copy link
Member

FWP from 15.0: #1151

Changes done:

  • Change t-esc and t-raw to t-out fromTrial Balance report
  • Refactor from Trial Balance
  • Add grouping by analytical account in Trial balance

ejemplo

Please @pedrobaeza can you review it?

@Tecnativa TT48969

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 29, 2024
pedrobaeza
pedrobaeza approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat.

As there's now the possibility of having more than one analytic account in the analytic field, we should put a warning banner in the wizard form to specify that there can be duplicated amounts due to that.

@victoralmau victoralmau force-pushed the 16.0-imp-account_financial_report-TT48969 branch from 6828e15 to 97ada3c Compare October 30, 2024 08:31
@pedrobaeza
Copy link
Member

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1243-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 7b4ad83 into OCA:16.0 Nov 26, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 7192e38. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-imp-account_financial_report-TT48969 branch November 26, 2024 08:13
This was referenced Nov 26, 2024
Merged
Closed
@primes2h primes2h mentioned this pull request Nov 26, 2024
Merged
@victoralmau victoralmau mentioned this pull request Dec 2, 2024
Merged
3 tasks
@micheledic micheledic mentioned this pull request Dec 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@carlosdauden carlosdauden carlosdauden approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @pedrobaeza @OCA-git-bot @carlosdauden