[16][FIX] account_financial_report : fix wizard model names sent to qweb reports for vat and aged balance reports #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reports for vat and aged balance reports
victoralmau
approved these changes
Oct 29, 2024
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at f8f5ec1. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue seems obvious, we get a wizard_id related to respectively
aged.partner.balance.report.wizardandvat.report.wizardmodels but we browse it with another model (open.items.report.wizard).As a result, if you try to read a field from the wizard in the qweb template, it will likely fail with an error like "The record is inexisting or has been deleted"
The problem does only appear in case of override of the qweb template and trying to read of field of the variable
owhich represent the wizard.I will forward port-it to 17.
A fast review is very welcome if you could as it is quite an easy one
@pedrobaeza @alexis-via @victoralmau @carlosdauden