Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] mis_builder_cash_flow: Allow to override query #1252

Conversation

SirAionTech
Copy link

In another module, we have added a column to mis.cash_flow.forecast_line and would like to use it in the MIS reports.

The problem is that the MIS reports do not use directly mis.cash_flow.forecast_line: they use the view mis.cash_flow that exposes only some selected fields of mis.cash_flow.forecast_line.

With this change, it is possible for other modules to change the view generation before it is executed.
This allows us to add the new column of mis.cash_flow.forecast_line in the view mis.cash_flow.

Any suggestion is appreciated: I admit I don't know MIS builder modules that well, so there may be other solutions for this use-case.
Please let me know what you think.

@OCA-git-bot
Copy link
Contributor

Hi @jjscarafia,
some modules you are maintaining are being modified, check this out!

@pedrobaeza pedrobaeza added this to the 16.0 milestone Nov 20, 2024
@rvalyi
Copy link
Member

rvalyi commented Nov 20, 2024

cc @marcelsavegnago

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 23, 2025
@rvalyi rvalyi removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 23, 2025
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1252-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 8db7fe0 into OCA:16.0 Mar 23, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b3c6a72. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants