[18.0][MIG] account_financial_report: Migration to 18.0 #1253

chaule97 · 2024-11-22T02:55:04Z

OCA Port: [17.0][FW] account_financial_report: multiple ports from 14.0 #1233
I have renamed account name "301" to "201" in TestTrialBalanceReport based on SQL logic matching account codes to group prefixes.
I have updated the test case test_05_all_accounts_loaded to only retrieve accounts with numeric codes, because there is account with string codes.

henrybackman · 2024-11-22T09:22:17Z

account_financial_report/report/templates/layouts.xml

+            <div class="row">
+                <div class="col-6 custom_footer">
+                    <span
+                        t-esc="context_timestamp(datetime.datetime.now()).strftime('%Y-%m-%d %H:%M')"


t-esc should be replaced with t-out
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

henrybackman · 2024-11-22T10:08:47Z

account_financial_report/wizard/general_ledger_wizard_view.xml

+                'default_payable_accounts_only':1,
+            }"
+        />
+        <field name="groups_id" eval="[(4, ref('account.group_account_manager'))]" />


groups_id should be replaced with groups= in the element
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0

henrybackman · 2024-11-22T10:41:21Z

account_financial_report/__manifest__.py

+# Author: Julien Coux
+# Copyright 2016 Camptocamp SA
+# Copyright 2020 ForgeFlow S.L. (https://www.forgeflow.com)
+# Copyright 2021 Tecnativa - Jo??o Marques


Suggested change

# Copyright 2021 Tecnativa - Jo??o Marques

# Copyright 2021 Tecnativa - João Marques

henrybackman · 2024-11-22T10:49:02Z

account_financial_report/models/account.py

@@ -0,0 +1,13 @@
+# ?? 2011 Guewen Baconnier (Camptocamp)


Suggested change

# ?? 2011 Guewen Baconnier (Camptocamp)

# © 2011 Guewen Baconnier (Camptocamp)

Check other files as well for similar issues

henrybackman · 2024-11-22T12:02:59Z

account_financial_report/report/aged_partner_balance.py

+        else:
+            ag_pb_data[acc_id]["older"] += residual
+            ag_pb_data[acc_id][prt_id]["older"] += residual
+        if due_date:


Is it possible to not have due_date? It is set on line 59 due_date = today

chaule97 · 2024-11-25T04:47:24Z

Hi @henrybackman, I have optimized the query, can you check it again?

salvorapi · 2024-11-25T14:08:51Z

LGTM

OCA-git-bot · 2024-11-27T03:50:24Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

victoralmau · 2024-11-29T08:21:31Z

Please add #1257 to commit history

Currently translated at 100.0% (329 of 329 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-account_financial_report/pt_BR/

The number of computed account can be greater in certain databases with l10n modules.

Currently translated at 10.3% (34 of 329 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-account_financial_report/fr/

Currently translated at 100.0% (329 of 329 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-account_financial_report/pt_BR/

Currently translated at 23.1% (76 of 329 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-account_financial_report/fr/

…rtner

…cade `report_journal_ledger` is auto-vacuumed as any transient model, but has some ondelete="cascade" constraints that auto-remove subtables when a record is removed, doing this operation very slow when selecting these sub-records. Letting default ondelete="set null" would result in same performance bottleneck, as the select on sub-table is performed the same for setting "null" value on them. As a solution, and for avoiding a costly index operation, we delete by SQL sub-tables rows in advance. A bit of extra logic has been added for avoiding to remove that records if it's not the turn of vacuum the parent table.

Currently translated at 84.5% (278 of 329 strings) Translation: account-financial-reporting-12.0/account-financial-reporting-12.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-12-0/account-financial-reporting-12-0-account_financial_report/fr/

* centralization is only calculated on accounts where 'centralized' is True * Cumul. Balance of each move_line fixed * Ordering move_lines by date * Fix trial_balance xlsx when not show_partner_details

Some reports crash if account move line implicated are Sections lines or Notes lines in an invoice

* Missing import causes failure when running Open Items with Date At in the past

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-financial-reporting-17.0/account-financial-reporting-17.0-account_financial_report Translate-URL: https://translation.odoo-community.org/projects/account-financial-reporting-17-0/account-financial-reporting-17-0-account_financial_report/

…General Ledger report

…als if the account has not set currency Related to OCA#1235 (comment) [FIX] account_financial_report: Avoid error in General ledger if the Show foreign currency checkbox is not checked. Related to OCA#1236 TT51996

chaule97 · 2024-11-29T09:26:59Z

Please add #1257 to commit history

thanks, I have added these commits

victoralmau · 2024-12-03T12:27:25Z

Please add #1258 to commit history.

…Trial Balance report TT48969

… Trial balance TT48969

victoralmau · 2024-12-04T07:32:19Z

Please add #1261 to commit history.

Some reports were failing to render without this fix. It seems there was a regression introduced in 0a2b273. @moduon MT-8285

pedrobaeza · 2024-12-06T18:19:00Z

/ocabot migration account_financial_report

pedrobaeza

Tested on runboat

/ocabot merge nobump

OCA-git-bot · 2024-12-06T18:21:25Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1253-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-12-06T18:26:31Z

Congratulations, your PR was merged at 5627c59. Thanks a lot for contributing to OCA. ❤️

henrybackman reviewed Nov 22, 2024

View reviewed changes

chaule97 force-pushed the 18.0-mig-account_financial_report branch from befa9ce to ff0b491 Compare November 25, 2024 04:38

chaule97 force-pushed the 18.0-mig-account_financial_report branch from ff0b491 to 8f9d339 Compare November 25, 2024 07:38

henrybackman approved these changes Nov 25, 2024

View reviewed changes

salvorapi approved these changes Nov 25, 2024

View reviewed changes

OCA-git-bot added the approved label Nov 25, 2024

OCA-git-bot added the ready to merge label Nov 27, 2024

eduaparicio and others added 19 commits November 29, 2024 15:38

[FIX] account_financial_report: Update to bootstrap 4

fb3f5cc

[FIX] account_financial_report: Don't fail with installed l10n

58b8015

The number of computed account can be greater in certain databases with l10n modules.

Fix display of captions in pdf

185940e

account_financial_report: fix Trial Balance line order

24c2432

[12.0][FIX] - Hide ending balance if general ledger is filtered by pa…

091a3f3

…rtner

Added translation using Weblate (Croatian)

b26ee9f

[12.0] account_financial_report: refactor

1227d53

[IMP] account_financial_report: black, isort

40c874a

[MIG] account_financial_report: Migration to 13.0

712d4a8

[FIX] account_financial_report: general_ledger

e23bfa9

* centralization is only calculated on accounts where 'centralized' is True * Cumul. Balance of each move_line fixed * Ordering move_lines by date * Fix trial_balance xlsx when not show_partner_details

[FIX] account_financial_report: Fix error when generating reports

db9f316

Some reports crash if account move line implicated are Sections lines or Notes lines in an invoice

[FIX] account_financial_report: open_items

72c6843

* Missing import causes failure when running Open Items with Date At in the past

OCA-git-bot and others added 7 commits November 29, 2024 15:38

[BOT] post-merge updates

de2e844

[UPD] Update account_financial_report.pot

6c4b97d

[BOT] post-merge updates

a67a805

[IMP] account_financial_report: Change t-esc and t-raw to t-out from …

01b2e35

…General Ledger report

[BOT] post-merge updates

f4a3a26

chaule97 force-pushed the 18.0-mig-account_financial_report branch from 8f9d339 to f403480 Compare November 29, 2024 09:22

chaule97 force-pushed the 18.0-mig-account_financial_report branch from f403480 to 8cd27bd Compare December 2, 2024 03:47

victoralmau added 2 commits December 4, 2024 10:12

[IMP] account_financial_report: Change t-esc and t-raw to t-out from …

e4e301a

…Trial Balance report TT48969

[IMP] account_financial_report: Add grouping by analytical account in…

0e6c436

… Trial balance TT48969

chaule97 force-pushed the 18.0-mig-account_financial_report branch 2 times, most recently from e439180 to 591eec6 Compare December 4, 2024 03:29

yajo and others added 3 commits December 4, 2024 14:40

[FIX] account_financial_report: KeyError rendering report

4413611

Some reports were failing to render without this fix. It seems there was a regression introduced in 0a2b273. @moduon MT-8285

[IMP] account_financial_report: pre-commit auto fixes

c46e83a

[MIG] account_financial_report: Migration to 18.0

01f22b8

chaule97 force-pushed the 18.0-mig-account_financial_report branch from 591eec6 to 01f22b8 Compare December 4, 2024 07:41

OCA-git-bot added this to the 18.0 milestone Dec 6, 2024

OCA-git-bot mentioned this pull request Dec 6, 2024

Migration to version 18.0 #1230

Open

4 tasks

pedrobaeza approved these changes Dec 6, 2024

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Dec 6, 2024

OCA-git-bot merged commit 470c4f3 into OCA:18.0 Dec 6, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Dec 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] account_financial_report: Migration to 18.0 #1253

[18.0][MIG] account_financial_report: Migration to 18.0 #1253

chaule97 commented Nov 22, 2024 •

edited

Loading

henrybackman Nov 22, 2024

henrybackman Nov 22, 2024

henrybackman Nov 22, 2024

henrybackman Nov 22, 2024

henrybackman Nov 22, 2024

henrybackman Nov 22, 2024

chaule97 commented Nov 25, 2024

salvorapi commented Nov 25, 2024

OCA-git-bot commented Nov 27, 2024

victoralmau commented Nov 29, 2024

chaule97 commented Nov 29, 2024

victoralmau commented Dec 3, 2024

victoralmau commented Dec 4, 2024

pedrobaeza commented Dec 6, 2024

pedrobaeza left a comment

OCA-git-bot commented Dec 6, 2024

OCA-git-bot commented Dec 6, 2024

	# Copyright 2021 Tecnativa - Jo??o Marques
	# Copyright 2021 Tecnativa - João Marques

	# ?? 2011 Guewen Baconnier (Camptocamp)
	# © 2011 Guewen Baconnier (Camptocamp)

[18.0][MIG] account_financial_report: Migration to 18.0 #1253

[18.0][MIG] account_financial_report: Migration to 18.0 #1253

Conversation

chaule97 commented Nov 22, 2024 • edited Loading

henrybackman Nov 22, 2024

Choose a reason for hiding this comment

henrybackman Nov 22, 2024

Choose a reason for hiding this comment

henrybackman Nov 22, 2024

Choose a reason for hiding this comment

henrybackman Nov 22, 2024

Choose a reason for hiding this comment

henrybackman Nov 22, 2024

Choose a reason for hiding this comment

henrybackman Nov 22, 2024

Choose a reason for hiding this comment

chaule97 commented Nov 25, 2024

salvorapi commented Nov 25, 2024

OCA-git-bot commented Nov 27, 2024

victoralmau commented Nov 29, 2024

chaule97 commented Nov 29, 2024

victoralmau commented Dec 3, 2024

victoralmau commented Dec 4, 2024

pedrobaeza commented Dec 6, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Dec 6, 2024

OCA-git-bot commented Dec 6, 2024

chaule97 commented Nov 22, 2024 •

edited

Loading