Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FIX] account_financial_report: KeyError rendering report #1262

Merged
merged 1 commit into from
Dec 4, 2024
Merged

[15.0][FIX] account_financial_report: KeyError rendering report #1262

merged 1 commit into from
Dec 4, 2024

Conversation

victoralmau
Copy link
Member

Backport from 16.0: #1260

Related to #1259

Some reports were failing to render without this fix.

Example of use case:

  • Define Account Currency (USD) to an account (101401 for example).
  • Display the General ledger report

@Tecnativa

@yajo @victoralmau
[FIX] account_financial_report: KeyError rendering report
e2bfb27 
Some reports were failing to render without this fix.

It seems there was a regression introduced in 0a2b273.

@moduon MT-8285
@pedrobaeza pedrobaeza added this to the 15.0 milestone Dec 4, 2024
pedrobaeza
pedrobaeza approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1262-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a0a7389 into OCA:15.0 Dec 4, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3d9c6d5. Thanks a lot for contributing to OCA. ❤️

@victoralmau victoralmau mentioned this pull request Dec 4, 2024
Closed
@pedrobaeza pedrobaeza deleted the 15.0-fix-account_financial_report-pr-1260 branch December 4, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.
4 participants
@victoralmau @OCA-git-bot @pedrobaeza @yajo