Skip to content

[18.0][MIG] account_journal_lock_date: Migration to 18.0 #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

StefanRijnhart
Copy link
Member

@StefanRijnhart StefanRijnhart commented Mar 7, 2025

Standard migration.

@StefanRijnhart StefanRijnhart changed the title [18.0][MIG] account_journal_lock_date [18.0][MIG] account_journal_lock_date: Migration to 18.0 Mar 7, 2025
@StefanRijnhart StefanRijnhart force-pushed the 18.0-mig-account_journal_lock_date branch 5 times, most recently from c1a0b0c to e5d9f0e Compare March 7, 2025 13:41
@StefanRijnhart StefanRijnhart marked this pull request as ready for review March 7, 2025 13:47
@StefanRijnhart
Copy link
Member Author

/ocabot migration account_journal_lock_date

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Mar 7, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 7, 2025
25 tasks
Copy link
Member

@Saran440 Saran440 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Test 👍

Copy link

@kanisorn-kate kanisorn-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@Saran440
Copy link
Member

@StefanRijnhart Can you check file conflict please?

sbidoul and others added 16 commits April 22, 2025 12:50
The test failed on travis (not on a local install) because the
admin users if part of the Adviser group. Make sure we have the right
group and add a test for that feature too.
- Change in journal the existing 'Lock date' by two dates, the same as in company.
- Add a wizard to allows a massive update of those dates for several journals at the same time.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_journal_lock_date
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_journal_lock_date/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-13.0/account-financial-tools-13.0-account_journal_lock_date
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-13-0/account-financial-tools-13-0-account_journal_lock_date/
ThijsvOers and others added 11 commits April 22, 2025 12:50
Currently translated at 100.0% (20 of 20 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_journal_lock_date
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_journal_lock_date/nl/
Currently translated at 100.0% (20 of 20 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_journal_lock_date
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_journal_lock_date/sv/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_journal_lock_date
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_journal_lock_date/
Currently translated at 100.0% (19 of 19 strings)

Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_journal_lock_date
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_journal_lock_date/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_journal_lock_date
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_journal_lock_date/ca/
Currently translated at 100.0% (19 of 19 strings)

Translation: account-financial-tools-17.0/account-financial-tools-17.0-account_journal_lock_date
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-17-0/account-financial-tools-17-0-account_journal_lock_date/ca/
@StefanRijnhart StefanRijnhart force-pushed the 18.0-mig-account_journal_lock_date branch from e5d9f0e to 3d06b0c Compare April 22, 2025 10:53
Fixes
```
ERROR odoo odoo.addons.account_journal_lock_date.tests.test_journal_lock_date: FAIL: TestJournalLockDate.test_journal_lock_date
odoo.exceptions.UserError: This document is protected by a hash. Therefore, you cannot edit the following fields: Number.
```
@StefanRijnhart StefanRijnhart force-pushed the 18.0-mig-account_journal_lock_date branch from 3d06b0c to f148a42 Compare April 22, 2025 11:14
@StefanRijnhart
Copy link
Member Author

@Saran440 Thanks for noting. Rebased and conflict resolved.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@StefanRijnhart
Copy link
Member Author

@OCA/accounting-maintainers this one should be ready for merge

@kittiu
Copy link
Member

kittiu commented May 22, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-2048-by-kittiu-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 22, 2025
Signed-off-by kittiu
@OCA-git-bot
Copy link
Contributor

It looks like something changed on 18.0 in the meantime.
Let me try again (no action is required from you).
Prepared branch 18.0-ocabot-merge-pr-2048-by-kittiu-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit f099e3a into OCA:18.0 May 22, 2025
9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 4e9caca. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.