Skip to content

[14.0] [MIG] account_fiscal_position_autodetect_optional_vies: Migration to 14.0 #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Tisho99
Copy link
Contributor

@Tisho99 Tisho99 commented May 29, 2024

Migration from 15.0 to 14.0

T-6135

victoralmau and others added 14 commits May 29, 2024 10:51
…dds vat VIES validation to fiscal positions.

TT30631
… type in test partner

After OCA/OCB@4518968#diff-1ef5fe83935572c9b9b9e6eec69a44551023f3b92fe38bed4f765a24e16694b4 and OCA/OCB@198a4dd the associated partner needs to be of type `company` for the vies check to work.

@Tecnativa
…n contacts

Steps to reproduce the problem:

- Create a partner with a proper VIES VAT.
- Create a children for that partner.
- Create a fiscal position with "Vat was VIES validated" and
  "Auto-apply" marks checked.
- Use the children partner in an invoice.

Current behavior:

The fiscal position is not selected.

Expected behavior:

The fiscal position is selected.

TT38107
@Tisho99 Tisho99 force-pushed the 14.0-mig-account_fiscal_position_autodetect_optional_vies branch from 8ef7ea6 to 02bbb33 Compare May 30, 2024 08:56
@Tisho99 Tisho99 marked this pull request as ready for review May 30, 2024 09:25
@Tisho99
Copy link
Contributor Author

Tisho99 commented May 30, 2024

@HaraldPanten
Copy link

/ocabot migration account_fiscal_position_autodetect_optional_vies

@OCA-git-bot OCA-git-bot added this to the 14.0 milestone May 30, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request May 30, 2024
5 tasks
@ValentinVinagre
Copy link
Contributor

@Jesarregui

Copy link

@Jesarregui Jesarregui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review: LGTM

@Jesarregui
Copy link

@ValentinVinagre Could you do a technical review?

Copy link
Contributor

@manuelregidor manuelregidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technical review. LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@HaraldPanten
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-430-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2e9ab84 into OCA:14.0 Jun 13, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6ec2933. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten HaraldPanten deleted the 14.0-mig-account_fiscal_position_autodetect_optional_vies branch June 13, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants