[14.0][IMP] add tax_scope to account.product.fiscal.classification #439
+53
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @legalsylvain, |
Comment on lines
+36
to
+43
| @api.depends("type") | ||
| def _compute_type_identification(self): | ||
| for product in self: | ||
| if product.type == "product": | ||
| product.tax_scope_identification = "consu" | ||
| else: | ||
| product.tax_scope_identification = product.type | ||
|
|
There was a problem hiding this comment.
why add a new field on product.product. You could just base your domain on the product.type field ?
thanks !
There was a problem hiding this comment.
It was the why i found to have the product.type "product" and "consu" on one label.
it may be to restrictive. but i don't found a other idea to get this.
Sorry, for the time. I misclick my answer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tax-scope to tax classification.
Tax in tax classification are filter with the values of the tax_scope.
On product, the tax_classification are filter with the type of product(consu or service)