Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.0][MIG] account_avatax_oca_log: Migration to 18.0 #460

Open
wants to merge 3 commits into
base: 18.0
Choose a base branch
from
Open

[18.0][MIG] account_avatax_oca_log: Migration to 18.0 #460

wants to merge 3 commits into from

Conversation

kobros-tech
Copy link

wlin-kencove
wlin-kencove reviewed Jan 8, 2025
View reviewed changes
Copy link

@wlin-kencove wlin-kencove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

As far as the logging goes this seems to be working locally.

dnplkndll
dnplkndll approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@dnplkndll dnplkndll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@dnplkndll
Copy link
Contributor

@JordiBForgeFlow you want to have a look?

@kobros-tech kobros-tech force-pushed the 18.0-mig-account_avatax_oca_log branch from 2e878e5 to 54f77c1 Compare January 16, 2025 06:17
wlin-kencove
wlin-kencove approved these changes Jan 31, 2025
View reviewed changes
Copy link

@wlin-kencove wlin-kencove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I loaded on a local instance and the review log works well for me. I see no issues there.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlin-kencove wlin-kencove wlin-kencove approved these changes

@dnplkndll dnplkndll dnplkndll approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kobros-tech @dnplkndll @OCA-git-bot @wlin-kencove @JordiBForgeFlow