[FIX] account_avatax_oca,account_avatax_sale_oca: present theoretical tax rate on invoices #479
+72
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreispt
force-pushed
the
17-dr-avatax-tax-refactor
branch
from
8560651 to
b8a9f05
Compare
dreispt
force-pushed
the
17-dr-avatax-tax-refactor
branch
from
b8a9f05 to
41518c7
Compare
dreispt
force-pushed
the
17-dr-avatax-tax-refactor
branch
from
41518c7 to
c0d998a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tax names used to represent taxes are changed, to show both the theoretical tax (e.g. "9.5%") and the real tax rate needed to Odoo to calculate the exact same cent value (e.g. "9.576%").
And on Invoiced we, want only the theoretical tax to be presented (e.g. "9.5%").
This was also a chance to refactor of the code related to Avalara tax code creation, that was reduced by removing redundancies.
Sample output for the the new Avalara tax naming approach: