Skip to content

[FIX] [16.0] account_invoice_report_product_sticker: Select which model are being requesting stickers #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Shide
Copy link

@Shide Shide commented Feb 19, 2025

Update how it works to match the new arguments.

This PR needs to be merged first in order to work: OCA/product-attribute#1893

MT-9075 @moduon @rafaelbn @yajo @fcvalgar @EmilioPascual please review if you want 😄

@OCA-git-bot
Copy link
Contributor

Hi @rafaelbn,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ 😄

@Shide Shide force-pushed the 16.0-select_model_to_use-account_invoice_report_product_sticker branch from ec8ed1f to 5f28469 Compare February 20, 2025 10:57
@Shide Shide force-pushed the 16.0-select_model_to_use-account_invoice_report_product_sticker branch from 5f28469 to 36bfb8b Compare February 20, 2025 11:00
@rafaelbn rafaelbn requested a review from fcvalgar February 21, 2025 11:29
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @Shide

@rafaelbn
Copy link
Member

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

@rafaelbn The rebase process failed, because command git push --force moduon tmp-pr-353:16.0-select_model_to_use-account_invoice_report_product_sticker failed with output:

remote: Permission to moduon/account-invoice-reporting.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/moduon/account-invoice-reporting/': The requested URL returned error: 403

@rafaelbn
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-353-by-rafaelbn-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 72f494f. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot OCA-git-bot merged commit 7808511 into OCA:16.0 Feb 24, 2025
3 of 5 checks passed
@Shide Shide deleted the 16.0-select_model_to_use-account_invoice_report_product_sticker branch February 24, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants