-
-
Notifications
You must be signed in to change notification settings - Fork 246
[ADD] New Module 17.0 Proforma Invoice #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 17.0
Are you sure you want to change the base?
Conversation
…updated manifest, views, and README
|
Hi, could you please review this PR when you get a chance? Thanks! |
|
Hello 👋, Kindly requesting a review on this PR whenever possible. All checks have passed successfully. Thank you for your time and contribution to the community! 🙏 @OCA/maintainers-account-invoice-reporting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed the Odoo module update:
- Code follows Odoo conventions
- XML views, models, and security files look good
- No functional or performance issues found in test
- workflows are properly handled
samarth32
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code aligns nicely with existing module structure and OCA standards.
Docstrings and inline comments improve maintainability—thank you for those!
|
Hi @OCA/maintainers-account-invoice-reporting The PR has been approved and CI is green. Kindly requesting a merge when convenient. Thanks for the review! |
|
This PR has the |
|
@antoniospneto please review and marge |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
dreispt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is "ARTX"?
I see this is actually a Sales Report, not a real Account invoice extension.
The module name is misleading, and the target repo should probably be oca/sale-workflow.
it isn't clear for me how this works with Odoo's Downpayment mechanism.
Isn't the additional fields duplicating the Downpayment line expected on the order?
This module enhances the default Odoo Sale module by allowing users to:
Perfect for businesses needing control over their delivery workflow and payment tracking.