-
-
Notifications
You must be signed in to change notification settings - Fork 246
[19.0][MIG] account_invoice_report_grouped_by_picking: Migration to 19.0 #382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 19.0
Are you sure you want to change the base?
Conversation
- When a return was in the original pickings it wasn't reflected in the corresponding invoices correctly. - Now we compute the total quantities of the moves recursively.
- When B2C prices was set, the orders where not properly grouped.
…iding edge cases * The grouping is fully done on the prepare method * It also computes the quantity applicable * Adapt views to B2C/B2B cleanly
… by zero when quantity is zero (OCA#101)
… in B2B when uses B2C
[FIX] account_invoice_report_grouped_by_picking: debug print remove [FIX] account_invoice_report_grouped_by_picking: remove debug variable
…also with the related SO picking Service lines that are not put on the pickings, remain on top of the invoice report due to this, but it has more sense to have them grouped in the same picking block than the rest of their sales order stockable lines. Tests and README adapted.
…change position=replace in report_invoice.xml to prevent errors
notes Avoid nasty exceptions. In the other hand it would be hard to fit the concept of sections and notes to the picking groups in which this report results. TT29507
… avoid crash test due to this Odoo commit OCA/OCB@8ca10a8
…lines for refund invoices without no returned quantities TT27550
…ngs & sales For manually created refund invoices that don't have pickings or orders, no lines were shown in the report
…ines After the patch on stock_picking_invoice_link to link the refund moves to the return pickings created before the refund. This module shows on the picking duplicated lines. With this patch the sign is correctly set and this duplication does not exist. TT39916
Consider pending pickings that are linked to the invoice. TT40412
…_qty missed by this PR: OCA#224 (review)
…lls to lines_grouped_by_picking
…rovement - Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (5 of 5 strings) Translation: account-invoice-reporting-17.0/account-invoice-reporting-17.0-account_invoice_report_grouped_by_picking Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-17-0/account-invoice-reporting-17-0-account_invoice_report_grouped_by_picking/es/
…tes without lines.
… when remaining_qty is near of zero Cherry-pick a38da1d
…plify and remove OrderedDict From Python 3.7 dictionaries maintain the insertion order, so OrderedDict is unnecessary and adds overhead.
84ba4e2 to
ca35016
Compare
ca35016 to
f7f3e46
Compare
Reyes4711-S73
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
pablo-cort-s73
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f7f3e46 to
c25d01d
Compare
yankinmax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technical migration LG.
Have you checked the report opens without issues on the runbot (functional validation)?
test-requirements.txt
Outdated
| odoo-addon-sale_stock_picking_invoice_link @ git+https://github.com/OCA/stock-logistics-workflow.git@refs/pull/2130/head#subdirectory=sale_stock_picking_invoice_link | ||
| odoo-addon-stock_picking_invoice_link @ git+https://github.com/OCA/stock-logistics-workflow.git@refs/pull/2127/head#subdirectory=stock_picking_invoice_link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are merged. Can you remove the test-requirements commit?
8bc0ee0 to
1d57b20
Compare
No description provided.