[18.0][MIG] account_invoice_show_currency_rate #1873

JordiMForgeFlow · 2025-01-03T08:04:27Z

Migration to V18:

Odoo adds a new field to display the currency rate on invoices when the currency is different than the company's currency (https://github.com/odoo/odoo/blob/e3d54695862f73d9be6c35121def57ed641a1a45/addons/account/models/account_move.py#L462). However, the computed rate is simply based on the rate configured in the system at the time of computing. It could be the case that a different rate was existing when the invoice was posted, so this module ensures that the rate computed for posted invoices is based on the actual currency amount applied.

FW of #1838:

Odoo computes the currency rate on journal items (https://github.com/odoo/odoo/blob/e3d54695862f73d9be6c35121def57ed641a1a45/addons/account/models/account_move_line.py#L133). However, the computed rate is based on the rate configured in the system. It could be the case for manually created entries that the user has manually modified the amount in currency, so this module ensures that the computed rate is based on the actual currency amount applied.

FW of #1899 and #1901

GuillemCForgeFlow

makes sense to me 👍🏿

AaronHForgeFlow

Functional + code

JasminSForgeFlow

Code review

OCA-git-bot · 2025-01-08T08:13:45Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

…orrect in the main company

…to avoid many decimal places (1.9974358974358974 for example).

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/

Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/es/

Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/it/

… rate

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/

Currently translated at 100.0% (4 of 4 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_show_currency_rate Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_show_currency_rate/it/

…y lines to get rate

…l items

… rate on credit amounts

…is zero

Currency rates are not rounded in Odoo. Applying the rounding causes the currency rate of the line to be different when the move is posted.

AlexPForgeFlow

LGTM!

JordiBForgeFlow · 2025-02-20T15:35:48Z

/ocabot merge

OCA-git-bot · 2025-02-20T15:35:52Z

Hi @JordiBForgeFlow. Your command failed:

Required option bumpversion_mode for command merge. Possible values : major, minor, patch, nobump.

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

JordiBForgeFlow · 2025-02-20T15:36:04Z

/ocabot merge nobump

OCA-git-bot · 2025-02-20T15:36:14Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-1873-by-JordiBForgeFlow-bump-nobump, awaiting test results.

OCA-git-bot · 2025-02-20T15:41:10Z

Congratulations, your PR was merged at 87369b8. Thanks a lot for contributing to OCA. ❤️

JordiMForgeFlow force-pushed the 18.0-mig-account_invoice_show_currency_rate branch from ba65629 to ac1d0a9 Compare January 3, 2025 08:15

JordiMForgeFlow marked this pull request as ready for review January 3, 2025 08:20

JordiMForgeFlow force-pushed the 18.0-mig-account_invoice_show_currency_rate branch from ac1d0a9 to 99425ae Compare January 3, 2025 08:31

GuillemCForgeFlow approved these changes Jan 3, 2025

View reviewed changes

AaronHForgeFlow approved these changes Jan 3, 2025

View reviewed changes

OCA-git-bot added the approved label Jan 3, 2025

JasminSForgeFlow approved these changes Jan 3, 2025

View reviewed changes

OCA-git-bot added the ready to merge label Jan 8, 2025

victoralmau and others added 21 commits February 3, 2025 16:49

[ADD] account_invoice_show_currency_rate: Show currency rate in invoices

5d994b9

[UPD] Update account_invoice_show_currency_rate.pot

5dc30cd

[UPD] README.rst

2a1b071

[IMP] account_invoice_show_currency_rate: Make sure the currency is c…

ade5750

…orrect in the main company

account_invoice_show_currency_rate 13.0.1.0.1

0bae061

[FIX] account_invoice_show_currency_rate: Use assertAlmostEqual in tests

dce3ca5

[FIX] account_invoice_show_currency_rate: Round currency_rate_amount …

972671d

…to avoid many decimal places (1.9974358974358974 for example).

account_invoice_show_currency_rate 13.0.1.0.2

a549518

[IMP] account_invoice_show_currency_rate: pre-commit stuff

d2d5bef

[MIG] account_invoice_show_currency_rate: Migration to 16.0

f2ec94a

[UPD] Update account_invoice_show_currency_rate.pot

5d3d2a3

[UPD] README.rst

006f726

account_invoice_show_currency_rate 16.0.1.0.1

15df77a

[UPD] README.rst

ab42b25

Added translation using Weblate (Italian)

a724f3f

[IMP] account_invoice_show_currency_rate: optional show journal items…

458c275

… rate

[FIX] account_invoice_show_currency_rate: Use TransactionCase for tests

49c297e

[UPD] Update account_invoice_show_currency_rate.pot

87242a7

OCA-git-bot and others added 12 commits February 3, 2025 16:49

[BOT] post-merge updates

0ea4325

[BOT] post-merge updates

3d1dd21

[FIX] account_invoice_show_currency_rate: use only debit from currenc…

5ae6c58

…y lines to get rate

[BOT] post-merge updates

b8a23f4

[IMP] : pre-commit auto fixes

59a287c

[MIG] account_invoice_show_currency_rate: Migration to 17.0

1aaa5c6

[IMP] account_invoice_show_currency_rate: add currency rate in journa…

9a86582

…l items

[IMP] account_invoice_show_currency_rate: use absolute balance to get…

1b8a138

… rate on credit amounts

[MIG] account_invoice_show_currency_rate: Migration to V18

1770c98

[IMP] account_invoice_show_currency_rate: prevent error when balance …

81d1628

…is zero

JordiMForgeFlow force-pushed the 18.0-mig-account_invoice_show_currency_rate branch from 99425ae to 81d1628 Compare February 3, 2025 15:49

[FIX] account_invoice_show_currency_rate: do not round currency rate

8ef45a8

Currency rates are not rounded in Odoo. Applying the rounding causes the currency rate of the line to be different when the move is posted.

AlexPForgeFlow approved these changes Feb 18, 2025

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Feb 20, 2025

OCA-git-bot merged commit 6e3088b into OCA:18.0 Feb 20, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Feb 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[18.0][MIG] account_invoice_show_currency_rate #1873

[18.0][MIG] account_invoice_show_currency_rate #1873

JordiMForgeFlow commented Jan 3, 2025 •

edited

Loading

GuillemCForgeFlow left a comment

AaronHForgeFlow left a comment

JasminSForgeFlow left a comment

OCA-git-bot commented Jan 8, 2025

AlexPForgeFlow left a comment

JordiBForgeFlow commented Feb 20, 2025

OCA-git-bot commented Feb 20, 2025

JordiBForgeFlow commented Feb 20, 2025

OCA-git-bot commented Feb 20, 2025

OCA-git-bot commented Feb 20, 2025

[18.0][MIG] account_invoice_show_currency_rate #1873

[18.0][MIG] account_invoice_show_currency_rate #1873

Conversation

JordiMForgeFlow commented Jan 3, 2025 • edited Loading

GuillemCForgeFlow left a comment

Choose a reason for hiding this comment

AaronHForgeFlow left a comment

Choose a reason for hiding this comment

JasminSForgeFlow left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jan 8, 2025

AlexPForgeFlow left a comment

Choose a reason for hiding this comment

JordiBForgeFlow commented Feb 20, 2025

OCA-git-bot commented Feb 20, 2025

JordiBForgeFlow commented Feb 20, 2025

OCA-git-bot commented Feb 20, 2025

OCA-git-bot commented Feb 20, 2025

JordiMForgeFlow commented Jan 3, 2025 •

edited

Loading