Skip to content

[18.0][MIG] account_invoice_check_total: Migration to 18.0 #1960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OCA-git-bot merged 32 commits into from
Dec 10, 2025
Merged

[18.0][MIG] account_invoice_check_total: Migration to 18.0 #1960

OCA-git-bot merged 32 commits into from
Dec 10, 2025

Conversation

@jdidderen
Copy link
Contributor

@jdidderen jdidderen commented Mar 28, 2025

No description provided.

jbaudoux
jbaudoux approved these changes Apr 23, 2025
View reviewed changes
Copy link

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

AaronHForgeFlow
AaronHForgeFlow approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

account_invoice_check_total/models/account_move.py Outdated
!= 0
):
raise ValidationError(
_(
Copy link
Contributor

@AaronHForgeFlow AaronHForgeFlow Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_(
self.env._(

Copy link
Contributor Author

@jdidderen jdidderen May 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done 👍

@jdidderen jdidderen force-pushed the 18.0-mig-account_invoice_check_total branch 3 times, most recently from 5d18f1e to ed068d0 Compare May 18, 2025 19:06
matteonext
matteonext approved these changes Oct 16, 2025
View reviewed changes
Copy link
Contributor

@matteonext matteonext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge?

@jbaudoux
Copy link

jbaudoux commented Oct 16, 2025

Is this module still of any use? It's now a standard odoo feature you can enable in the settings (quick edit mode for supplier invoices)

@jdidderen
Copy link
Contributor Author

jdidderen commented Oct 18, 2025

@jbaudoux I know, but I’m a bit puzzled about this, because the quick edit mode isn’t limited to that feature.
In our case, this module is mainly used by customers whose administrative staff have limited accounting knowledge and are only responsible for encoding invoices. The module acts as a safeguard, but, for example, in quick edit mode the bill date is automatically filled in which isn’t always desired. Some customers prefer it to remain empty to avoid having a default date applied. So, enabling quick edit mode will likely require additional custom code to handle these cases properly.

alexis-via
alexis-via approved these changes Nov 14, 2025
View reviewed changes
Copy link
Contributor

@alexis-via alexis-via left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using format_amount() in the error message would be a great addition. I have a PR for this on 16.0 #2165

@jdidderen jdidderen force-pushed the 18.0-mig-account_invoice_check_total branch from a10354e to 51584fb Compare November 17, 2025 08:24
@jdidderen
Copy link
Contributor Author

jdidderen commented Nov 17, 2025

@alexis-via I have cherry picked your commit

Can we have this merged ?

ThomasBinsfeld and others added 17 commits December 10, 2025 17:16
@ThomasBinsfeld @jdidderen
account_invoice_check_total
bf17131
@jdidderen
Add group_supplier_inv_check_total on account.config.settings
3b8490d
@ThomasBinsfeld @jdidderen
PEP8, code lisibility, cosmetics
ba45dc1
@jdidderen
Migration of account_invoice_check_total to 10.0
c697d81
@sbidoul @jdidderen
[UPD] fix website url in manifest
2e1b5cb
@rven @jdidderen
[11.0][MIG] account_invoice_check_total: Migration to 11.0
cc5b785
@jdidderen
Translated using Weblate (Dutch)
a07b182 
Currently translated at 85,7% (6 of 7 strings)

Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_check_total/nl_NL/
@rven @jdidderen
[MIG] account_invoice_check_total: Migration to 12.0
47699fa
@astirpe @jdidderen
[IMP] account_invoice_check_total: improve ux
9d216bf
@primes2h @jdidderen
Translated using Weblate (Italian)
71bd29c 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_check_total/it/
@jesusVMayor @jdidderen
Translated using Weblate (Spanish)
982b7c3 
Currently translated at 50.0% (4 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_check_total/es/
@mvrodriguez @jdidderen
Translated using Weblate (Spanish)
978cfc5 
Currently translated at 62.5% (5 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_check_total/es/
@BECJIE32 @jdidderen
Translated using Weblate (French+Spanish)
ccaa7d9 
Translated using Weblate (French)

Currently translated at 87.5% (7 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_check_total/fr/

Translated using Weblate (Spanish)

Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_check_total/es/
@marylla @jdidderen
Translated using Weblate (German)
7195b3e 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_check_total/de/

[UPD] README.rst
@jdidderen
Translated using Weblate (Portuguese (Brazil))
eb7f4ac 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_check_total/pt_BR/
@pedrocs-exo @jdidderen
Translated using Weblate (Portuguese)
bf810af 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_check_total/pt/
@sysadminmatmoz @jdidderen
Translated using Weblate (Slovenian)
5a5eff5 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_check_total/sl/
Ernesto Tejeda and others added 15 commits December 10, 2025 17:16
@jdidderen
[IMP] account_invoice_check_total: black, isort, prettier
1856049
@jdidderen
[MIG] account_invoice_check_total: Migration to 13.0
2dc3abf 
[UPD] Update account_invoice_check_total.pot

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_check_total/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_check_total/
@anasuarez1 @jdidderen
Translated using Weblate (Spanish)
b0ac1c5 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-13.0/account-invoicing-13.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-13-0/account-invoicing-13-0-account_invoice_check_total/es/
@xavierjimenez @jdidderen
[MIG] account_invoice_check_total: Migration to 14.0
f887a70
@acsonefho @jdidderen
[14.0][FIX] account_invoice_check_total FR translation
1575cd6
@koenloodts @jdidderen
[MIG] account_invoice_check_total: Migration to 15.0
c5c92f6
@AnizR @jdidderen
[MIG][16] account_invoice_check_total
5b7fa6a 
Minor changes according to request
@badbole @jdidderen
Translated using Weblate (Croatian)
8e29c54 
Currently translated at 87.5% (7 of 8 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_check_total/hr/
@adrianojprado @jdidderen
Translated using Weblate (Portuguese (Brazil))
a5b4c74 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_check_total/pt_BR/
@Ivorra78 @jdidderen
Translated using Weblate (Spanish)
bab0154 
Currently translated at 100.0% (8 of 8 strings)

Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_check_total
Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_check_total/es/
@moitabenfdz @jdidderen
[IMP] account_invoice_check_total: pre-commit stuff
9ba2de6
@moitabenfdz @jdidderen
[MIG]account_invoice_check_total: Migration to 17.0
4bbd433
@jdidderen
[IMP] account_invoice_check_total: pre-commit execution
b6f5854
@jdidderen
[MIG] account_invoice_check_total: Migration to 18.0
371b469
@alexis-via @jdidderen
[IMP] account_invoice_check_total: use format_amount()
cfdddc4
@jdidderen jdidderen force-pushed the 18.0-mig-account_invoice_check_total branch from 51584fb to cfdddc4 Compare December 10, 2025 16:16
@jdidderen jdidderen mentioned this pull request Dec 10, 2025
Open
@alexis-via
Copy link
Contributor

alexis-via commented Dec 10, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Dec 10, 2025

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1960-by-alexis-via-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2aba890 into OCA:18.0 Dec 10, 2025
9 of 11 checks passed
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Dec 10, 2025

Congratulations, your PR was merged at e67f446. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexis-via alexis-via alexis-via approved these changes

@AaronHForgeFlow AaronHForgeFlow AaronHForgeFlow approved these changes

+3 more reviewers

@jbaudoux jbaudoux jbaudoux approved these changes

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes

@matteonext matteonext matteonext approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.