[13.0][MIG] account_cash_discount modules #334

benwillig · 2020-06-08T14:41:52Z

Migration of:

account_cash_discount_base
account_cash_discount_payment
account_cash_discount_write_off

Cedric-Pigeon

LGTM (code review only).

Could you please check why runbot is red ?

pedrobaeza · 2020-06-15T06:43:26Z

Do you know account_global_discount and corresponding modules that perform the same in a general manner?

benwillig · 2020-06-16T06:34:04Z

LGTM (code review only).

Could you please check why runbot is red ?

travis is fixed now

eguane · 2020-07-12T23:33:28Z

Hi, did you expect to backport it to v12 ?
between 80% and 90% of company in belgium using cash discount with this scenario: deducted discount from amount total without reducing VAT base, is it possible with your module.
Rgds

benwillig · 2020-07-13T10:20:32Z

Hi, did you expect to backport it to v12 ?
between 80% and 90% of company in belgium using cash discount with this scenario: deducted discount from amount total without reducing VAT base, is it possible with your module.
Rgds

Not at the moment, but I think it shouldn't be so hard to migrate this from 10.0 to 12.0

eguane · 2020-07-14T06:37:45Z

Hi, did you expect to backport it to v12 ?
between 80% and 90% of company in belgium using cash discount with this scenario: deducted discount from amount total without reducing VAT base, is it possible with your module.
Rgds

Not at the moment, but I think it shouldn't be so hard to migrate this from 10.0 to 12.0

Thank for your feedback, I tested V13 module, I probably miss something into the configuration. Company discount and payment term are both configured. When I try to add payment from the invoice, The amount proposed is always the invoice one, not discounted. Also if not already embeded, is it envisageable to add the value of the discount into a comment on the invoice, like "cash discount of xxx€ if paid before end date xx/xx/xx"
Can you confirm that the scenario deducted discount from amount total without reducing VAT base, is it possible with your module?
Rgds

sbidoul · 2020-09-30T15:15:07Z

cross referencing account_financial_discount that covers a similar scope: OCA/account-financial-tools#1040

sanrav · 2020-10-01T13:53:21Z

functional testing OK

dreispt · 2021-07-19T20:18:33Z

/ocabot merge nobump

OCA-git-bot · 2021-07-19T20:18:45Z

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-334-by-dreispt-bump-nobump, awaiting test results.

Signed-off-by dreispt

OCA-git-bot · 2021-07-19T20:20:48Z

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-334-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[ADD] Allow to configure discount options directly on the payment term [ADD] Add account cash discount payment module [MIG] account_cash_discount_payment migration. Also removed force_discount_amount from the account.invoice [ADD] Allow to tell if a payment line is paid using the discount or not. Keep the original amount in order to compute it again

…iscount) from a payment order

…iscount

[ADD] allow to toggle the discount on the payment order even if the discount due date is in the past [FIX] force to load discount payment term options when the partner changes

…of invoices (add sum and optional)

When the payment line create the account.move.line, tag_ids are not filled and so audit_tax still empty too. Fix + adapt unit test

acsonefho · 2022-05-25T12:22:06Z

@sbidoul @adrienpeiffer Is it possible to review and merge this PR please? Thanks! (I see you in contributors)

acsonefho · 2022-05-25T12:23:26Z

@dreispt

/ocabot merge nobump

Can you review and merge please?

adrienpeiffer

LGTM

OCA-git-bot · 2022-05-25T13:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt · 2022-05-25T13:49:17Z

/ocabot merge nobump

OCA-git-bot · 2022-05-25T13:49:26Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 13.0-ocabot-merge-pr-334-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot · 2022-05-25T13:56:37Z

Congratulations, your PR was merged at 6091d59. Thanks a lot for contributing to OCA. ❤️

benwillig force-pushed the 13.0-mig-account_cash_discount branch from fa84b31 to 658bf9e Compare June 10, 2020 09:18

benwillig changed the title ~~[WIP][13.0][MIG] account_cash_discount modules~~ [13.0][MIG] account_cash_discount modules Jun 10, 2020

Cedric-Pigeon approved these changes Jun 15, 2020

View reviewed changes

benwillig force-pushed the 13.0-mig-account_cash_discount branch from 658bf9e to ff1c4a3 Compare June 16, 2020 05:56

benwillig force-pushed the 13.0-mig-account_cash_discount branch from 56443de to d170dbd Compare September 30, 2020 09:02

sbidoul mentioned this pull request Sep 30, 2020

[13.0] Create module account_financial_discount OCA/account-financial-tools#1040

Closed

benwillig force-pushed the 13.0-mig-account_cash_discount branch from d170dbd to ea5696b Compare October 5, 2020 07:52

acsonefho force-pushed the 13.0-mig-account_cash_discount branch from ea5696b to 2b2a11e Compare October 21, 2020 09:16

acsonefho mentioned this pull request Nov 10, 2020

[13.0][ADD] account_cash_discount_base add field discount_option #371

Closed

baimont mentioned this pull request Apr 23, 2021

[13.0][IMP] account_cash_discount_payment - when confirming a payment order, payment date should be discount due date when possible #410

Closed

OCA-git-bot added a commit that referenced this pull request Jul 19, 2021

Merge PR #334 into 13.0

e7285cc

Signed-off-by dreispt

OCA-git-bot added the bot is merging ⏳ label Jul 19, 2021

OCA-git-bot removed the bot is merging ⏳ label Jul 19, 2021

TDu mentioned this pull request Oct 12, 2021

[13.0][ADD] ebill_paynet_account_financial_discount OCA/l10n-switzerland#586

Closed

1 task

adrienpeiffer and others added 6 commits January 12, 2022 10:43

[ADD] Add account cash discount module

abc4a63

[FIX][account_cash_discount_base] Some fixes

682720b

[ADD] Module which create a writeoff when paying an invoice (with a d…

1996c56

…iscount) from a payment order

[CHG] store the invoice's discount amount and the amount total with d…

93a89ca

…iscount

[FIX] Update file's headers (copyright, encoding)

56e339b

benwillig and others added 13 commits January 12, 2022 10:43

[FIX] Hide pay_with_discount field in the payment order line view

d81f346

[ADD] allow to toggle the discount on the payment order even if the discount due date is in the past [FIX] force to load discount payment term options when the partner changes

[UPD] Update account_cash_discount_base.pot

f88aefd

[UPD] Update account_cash_discount_payment.pot

2d21d91

[UPD] Update account_cash_discount_write_off.pot

b7a1f05

[ADD] icon.png

711a7ce

[WIP] account_cash_discount_base/write_off/payment migration

56e64ae

[MIG] account_cash_discount_base to v13

e5d4065

[MIG] account_cash_discount_payment to v13

70c7d81

[MIG] account_cash_discount_write_off to v13

d47e464

[FIX] pre-commit

a53d7a3

[FIX] updated /po files to prevent errors

432727e

[ADD] allow to handle discount on customer invoices + edit tree view …

59229f4

…of invoices (add sum and optional)

[FIX] Fix pre-commit + generate README

111b0c1

acsonefho force-pushed the 13.0-mig-account_cash_discount branch from db66bef to 9abb088 Compare January 13, 2022 12:53

[13.0][FIX] account_cash_discount_write_off: empty tax_audit

444ae4d

When the payment line create the account.move.line, tag_ids are not filled and so audit_tax still empty too. Fix + adapt unit test

acsonefho force-pushed the 13.0-mig-account_cash_discount branch from 9abb088 to 444ae4d Compare January 25, 2022 13:57

adrienpeiffer approved these changes May 25, 2022

View reviewed changes

OCA-git-bot added approved ready to merge labels May 25, 2022

OCA-git-bot added the bot is merging ⏳ label May 25, 2022

OCA-git-bot merged commit 64aa784 into OCA:13.0 May 25, 2022

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 25, 2022

acsonefho deleted the 13.0-mig-account_cash_discount branch May 30, 2022 06:33

Uh oh!

[13.0][MIG] account_cash_discount modules #334

[13.0][MIG] account_cash_discount modules #334

Uh oh!

Conversation

benwillig commented Jun 8, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Cedric-Pigeon left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Jun 15, 2020

Uh oh!

benwillig commented Jun 16, 2020

Uh oh!

eguane commented Jul 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

benwillig commented Jul 13, 2020

Uh oh!

eguane commented Jul 14, 2020

Uh oh!

sbidoul commented Sep 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sanrav commented Oct 1, 2020

Uh oh!

dreispt commented Jul 19, 2021

Uh oh!

OCA-git-bot commented Jul 19, 2021

Uh oh!

OCA-git-bot commented Jul 19, 2021

Uh oh!

acsonefho commented May 25, 2022

Uh oh!

acsonefho commented May 25, 2022

Uh oh!

adrienpeiffer left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented May 25, 2022

Uh oh!

dreispt commented May 25, 2022

Uh oh!

OCA-git-bot commented May 25, 2022

Uh oh!

OCA-git-bot commented May 25, 2022

Uh oh!

Uh oh!

benwillig commented Jun 8, 2020 •

edited

Loading

eguane commented Jul 12, 2020 •

edited

Loading

sbidoul commented Sep 30, 2020 •

edited

Loading