Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] account_payment_term_discount: add migration script #741

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

JordiBForgeFlow
Copy link
Member

the field 'discount' in the payment term line was defined in this module, but as of 16.0 the field 'discount_percentage' is applied already.

With this script we are copying the value from the previous column to the new one.

cc @ChrisOForgeFlow @AlexPForgeFlow

the field 'discount' in the payment term line was defined in this module,
but as of 16.0 the field 'discount_percentage' is applied already.

With this script we are copying the value from the previous column to the new one.
@OCA-git-bot
Copy link
Contributor

Hi @bodedra,
some modules you are maintaining are being modified, check this out!

Copy link
Member

@bodedra bodedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@ChrisOForgeFlow ChrisOForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link

github-actions bot commented Nov 3, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants