-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] agreement: Migration to 17.0 #35
Conversation
9d1b1f6
to
ebb529e
Compare
/ocabot migration agreement |
/ocabot rebase |
we move the is_template field definition and the agreement.type model from the agreement_legal module to the agreement module. The fields are not displayed by default, unless the feature is enabled through a technical feature group, this is configurable in the agreement_sale module (because agreement in itself has no UI, and agreement_legal enables the feature by default)
- The `agreement` model now features mail and activities from its base module. - The `agreement_legal` module doesn't need to add mail support now. - Add activities to form views. @Tecnativa TT22477
Update agreement and agreement_sale to restore the behavior of v10
…ad of onchange field
Congratulations, PR rebased to 17.0. |
ebb529e
to
2e2980a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just waiting for the change suggested @ramiadavid
This PR has the |
Co-authored-by: Denis Roussel (ACSONE) <[email protected]>
/ocabot merge nobump |
1 similar comment
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 7a74f0c. Thanks a lot for contributing to OCA. ❤️ |
No description provided.