[14.0] account_payment_order: Add pre_init_hook to add computed columns #1022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add columns to avoid MemoryError on an existing Odoo instance with lots of data. payment_order_ok on account.move is computed from payment_order_ok on account.payment.mode which are both introduced by this module, so nothing to compute. (see AccountMove._compute_payment_order_ok() in models/account_move.py) partner_bank_id on account.move.line requires payment_order_ok to be True which it won't be as it's newly introduced - again nothing to compute. (see AccountMoveLine._compute_partner_bank_id() in models/account_move_line.py)
dannyadair
changed the title
|
|
|
@pedrobaeza Thank you very much for the quick review! I've adjusted the hook accordingly. |
pedrobaeza
approved these changes
Jan 23, 2023
|
/ocabot merge patch Can you fw-port it to 15? |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 24a35a0. Thanks a lot for contributing to OCA. ❤️ |
Submitted #1047 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add columns to avoid MemoryError on an existing Odoo instance with lots of data.
payment_order_ok on account.move is computed from payment_order_ok on account.payment.mode which are both introduced by this module, so nothing to compute.
(see AccountMove._compute_payment_order_ok() in models/account_move.py)
partner_bank_id on account.move.line requires payment_order_ok to be True which it won't be as it's newly introduced - again nothing to compute. (see AccountMoveLine._compute_partner_bank_id() in models/account_move_line.py)