[17.0] [MIG] account_payment_partner #1183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- account_payment_partner - account_payment_sale - account_payment_sale_stock - account_payment_purchase Filter the selection of invoices per payment type. Add active field on payment.mode and payment.mode.type. Add menu entry for Payment Types.
* Migration and enhancement of all modules involved in SEPA * Clean files * Replace deprecated workflow calls * Translation template files * Translations to spanish * Use sale_ok and purchase_ok instead of tweaking payment type
* IMP: Add filter group by payment mode in account invoices * FIX: Remove deprecated tag type
* move unused file + cleanup code * Add sale_ok and purchase_ok filters in partner/sale/purchase form views * Use widget=selection for payment_mode_id fields * Update demo data * Return res in inherit (even if res is empty in this case)
…hout invoice (manual entries in receivables/payables)
FIX tabs FIX translate
* Forgot to remove a usecase of debit_denied * Add ACL * Better filters on payment.order.create wizard * Add default values for those filters on payment.mode * FIX remove coma at end of line * Add translatable 'label' field on payment.mode, designed to be used in invoice report
* Short headers * Remove label field There's already a field in the payment mode called 'note' that is printed on the invoices, so there's no need of another field for that purpose. This field is added by account_banking_payment_export * Bump version numbers * es translations * Name to filter for better inheratiblity
… a lot of improvements) during the Sorrento Code sprint 2016 Improvements include: - full re-organisation of modules and big re-organisation of the code - simplification of the code related to the fact that support for direct debit is now in t he base module, not added by an optional module account_direct_debit (module was removed) - new design of the wizard to select move lines to pay - support for non-SEPA file transfer- - support for German direct debit SEPA files (fixes bug OCA#129) - remove workflow of payment.order * Finalise the wizard of selection of move lines to pay * Add button "Add to payment/debit order" on invoice form view * Started to integrate payment transfer in account_payment_order (not finished at all though) * Copy payment mode and mandate from invoice to refund * Run dos2unix on the few files that had DOS carriage return * Add _id suffix on M2O fields customer_payment_mode and supplier_payment_mode (Odoo did the same on all the M2O property fields of res.partner) * Better handling of partner_bank_id and mandate_id on invoice: invisible/required/onchange * Move field bank_account_required from module account_payment_partner to account_payment_mode
Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
* Change copyright and author after company merging * Fill payment mode in invoices if none is provided Using same method as in upstream, payment mode is filled on invoice creation if no payment method is provided. This way, we don't need to install account_payment_sale if we don't want to handle several payment modes at sales level. Even more, if we install the module later and we have already existing sales orders without payment mode filled, those orders will be invoiced with the customer payment mode. * Signature changed in convert_to_write
…ompany in partner (OCA#438)
… not mandatory) and create a traceback for the user Use t-if
Currently translated at 100,0% (18 of 18 strings) Translation: bank-payment-11.0/bank-payment-11.0-account_payment_partner Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_payment_partner/es/
…on + show it on invoice report * IMP: Add options to show partner bank account on invoice report * FIX: Don't auto-assign partner bank account due to problems when you have a direct debit payment method with bank_account_link = 'fixed'. Bank account is shown through new mechanism.
miquelalzanillas
force-pushed
the
17.0-mig-account_payment_partner
branch
from
1e9a9b4 to
4e38597
Compare
15 tasks
miquelalzanillas
force-pushed
the
17.0-mig-account_payment_partner
branch
from
4e38597 to
22c9274
Compare
|
Hi @pedrobaeza , tests are failing for a missing module dependency for which I also have an open PR #1182. Do I have to wait now until the PR is merged for push again here to re-run tests? |
|
Thanks! |
|
Ready. Please review: @peluko00 @lbarry-apsl @javierobcn |
miquelalzanillas
changed the title
miquelalzanillas
force-pushed
the
17.0-mig-account_payment_partner
branch
from
25ffa30 to
1b315f8
Compare
samoros1
approved these changes
Nov 24, 2023
|
/ocabot migration account_payment_partner |
miquelalzanillas
force-pushed
the
17.0-mig-account_payment_partner
branch
from
1b315f8 to
22c9274
Compare
pedrobaeza
reviewed
Nov 25, 2023
| name="payment_mode_id" | ||
| force_save="1" | ||
| invisible="account_type not in ['asset_receivable', 'liability_payable']" | ||
| readonly="account_type not in ['asset_receivable', 'liability_payable'] or reconciled == True" |
There was a problem hiding this comment.
And the same for similar cases with booleans:
Suggested change
| readonly="account_type not in ['asset_receivable', 'liability_payable'] or reconciled == True" | |
| readonly="account_type not in ['asset_receivable', 'liability_payable'] or reconciled" |
There was a problem hiding this comment.
Fixed. Thanks.
miquelalzanillas
force-pushed
the
17.0-mig-account_payment_partner
branch
from
22c9274 to
4d1c73b
Compare
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 35c4c67. Thanks a lot for contributing to OCA. ❤️ |
| else: | ||
| move.partner_bank_id = False | ||
| else: | ||
| move.partner_bank_id = False |
There was a problem hiding this comment.
@miquelalzanillas @grindtildeath I'm wondering why removing the bank if it is already set and no payment mode ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
49 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: