[17.0][MIG] account_payment_sale: Migration to 17.0 #1186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- account_payment_partner - account_payment_sale - account_payment_sale_stock - account_payment_purchase Filter the selection of invoices per payment type. Add active field on payment.mode and payment.mode.type. Add menu entry for Payment Types.
* Migration and enhancement of all modules involved in SEPA * Remove duplicated files * Check if payment mode is set in the propagation * Clean files * account_payment_sale_stock: Split for removing stock dependency on sale * Remove old translations templates * Reorder on folder structure * Translation template files * Translations to spanish * Use sale_ok and purchase_ok instead of tweaking payment type * Add sale_ok and purchase_ok filters in partner/sale/purchase form views * Use widget=selection for payment_mode_id fields * Update demo data
Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
…d from a call to sale.action_invoice_create Into the normal process of the invoice creation from a sale order by odoo, the onchange_partner is called. In some case, this call will reset the specific payment_mode and/or partner_bank_id set on the sale_order. To fix this issue, we must override the _finalize_invoices method, take a snapshot of these values before the call to super and restore these values if these are changed. fixes OCA#536
…irect_debit Steps to reproduce the problem: - Set a payment mode with fixed journal and set the journal with bank account A. - Create a sales order and put bank account B. - Create invoice. - Bank account in invoice is A instead of B.
The expected one is to not have partner bank set, as we don't want the invoice is printed with such bank account forced.
Remove inherit of sale.advance.payment.inv: no need to inherit _prepare_invoice_values() because it calls _prepare_invoice() from the sale.order object
|
/ocabot migration account_payment_sale |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at f63ab8c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.