[17.0][MIG] account_banking_sepa_direct_debit #1239

JasminSForgeFlow · 2024-03-18T10:25:03Z

Standard Migration

@FrogeFlow

Depends on:

[17.0][MIG] account_banking_pain_base: Migration to 17.0 #1231

account_banking_sepa_direct_debit/data/mandate_expire_cron.xml

HaraldPanten · 2024-03-23T18:59:34Z

@JasminSForgeFlow This PR is ready to rebased. On the other hand, you're modifying two different modules.

1- The migration of account_banking_sepa_direct_debit.
2- FIX for account_banking mandate.

Could you separate that in two different PR? One for the migration and the other one for the FIX?

THX

HaraldPanten · 2024-03-28T10:16:09Z

Hi @MiquelRForgeFlow @JasminSForgeFlow Did you have availability to check my comments?

THX!

pedrobaeza · 2024-04-01T06:54:14Z

Please rebase and fix CI, and include #1244

HaraldPanten · 2024-04-02T16:10:02Z

/ocabot miggration account_banking_sepa_direct_debit

OCA-git-bot · 2024-04-02T16:10:06Z

Hi @HaraldPanten. Your command failed:

Invalid command: miggration.

Ocabot commands

ocabot merge major|minor|patch|nobump
ocabot rebase
ocabot migration {MODULE_NAME}

More information

ocabot documentation
OCA guidelines, specially the "Version Numbers" section.

HaraldPanten · 2024-04-02T16:10:35Z

/ocabot migration account_banking_sepa_direct_debit

….001.02, pain.008.001.03 and pain.008.001.04. This module is not ready yet : the management of mandates is still missing. I am currently trying to get more information about these mandates to decide what is the best implemtation of the data model of the mandates (O2M on res.partner ? O2M os res.partner.bank ?).

* Restore scheme field in mandate view * Uncaught flake8 errors * Set args correctly for cron job * Split for removing stock dependency on sale * Remove old translations templates * More reorder on folder structure * Translation template files * Translations to spanish

* Transfer move: one transfer move for each payment.order with only 1 line in the transfer account for the total of the account move. Move the inherit of the 'Invoice' button of payment.order from account_banking_payment_transfer to account_banking_payment_export Demo data: Add a bank account + mandate on Agrolait, to be able to easily test multi-partner SEPA DD * mandates: search by reference, add group_by, add seq type in tree view * Add scheme in mandate tree+search view Replace tabs by spaces in mandate views account_banking_mandate/views/account_banking_mandate_view.xml: convert from dos to unix format * Add sale_ok and purchase_ok filters in partner/sale/purchase form views Use widget=selection for payment_mode_id fields Update demo data * Limit lenght of mandate reference, according to ISO 20022

…f payment order

Fix an important regression in account_banking_sepa_direct_debit: "Date of Last Debit" was not set any more Proper write of date_done with account_banking_payment_export is installed without account_banking_payment_transfer Add post-install script for date_sent on payment.order

…ion when there is more than one line with the same mandate.

* Add bank.payment.lines object to allow grouping in the payments * Add a hook to inherit grouping of the transfer account move line Use that new hook in SEPA direct debits Better variable names * FIX Reading wrong field for sequence type of SEPA DD Loop on bank payment lines instead of payment lines * Update automated tests and demo data * Add on_change on field 'type' of payment.mode for easier configuration

… numbers + es translations

* Remove unused POT files * Spanish translation * Fix mandate report layout

Currently translated at 100.0% (74 of 74 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_sepa_direct_debit Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_sepa_direct_debit/es/

The field 'sepa' on account.payment.order is only display for SEPA payment methods. If the option "show warning if not SEPA" is enabled on the payment method, a warning banner is now displayed on payment orders with a SEPA payment method which are not SEPA.

Currently translated at 22.9% (17 of 74 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_banking_sepa_direct_debit Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_sepa_direct_debit/it/

…r email

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-16.0/bank-payment-16.0-account_banking_sepa_direct_debit Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_banking_sepa_direct_debit/

JasminSForgeFlow · 2024-04-03T06:03:19Z

@JasminSForgeFlow This PR is ready to rebased. On the other hand, you're modifying two different modules.

1- The migration of account_banking_sepa_direct_debit. 2- FIX for account_banking mandate.

Could you separate that in two different PR? One for the migration and the other one for the FIX?

THX

Done, Thanks

JasminSForgeFlow · 2024-04-03T06:03:34Z

Please rebase and fix CI, and include #1244

Done, Thanks

HaraldPanten · 2024-04-12T15:19:12Z

LGTM @pedrobaeza

Last tests should be directly in a production environment.

WDYT?

pedrobaeza · 2024-04-13T10:49:01Z

account_banking_sepa_direct_debit/models/mail_compose_message.py

-            auto_commit=auto_commit
-        )
+                self.env[wizard.model].sudo().browse(
+                    json.loads(wizard.res_ids)


Why do you need to convert it to JSON?

It is returning list in string format that's why

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2024-04-15T06:41:13Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2024-04-15T06:43:25Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-1239-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-04-15T06:50:43Z

Congratulations, your PR was merged at d76fdea. Thanks a lot for contributing to OCA. ❤️

TA23146

MiquelRForgeFlow reviewed Mar 18, 2024

View reviewed changes

account_banking_sepa_direct_debit/data/mandate_expire_cron.xml Outdated Show resolved Hide resolved

JasminSForgeFlow force-pushed the 17.0-mig-account_banking_sepa_direct_debit branch from 0784a40 to 5183f50 Compare March 20, 2024 03:28

OCA-git-bot added this to the 17.0 milestone Apr 2, 2024

OCA-git-bot mentioned this pull request Apr 2, 2024

Migration to version 17.0 #1173

Open

15 tasks

Alexis de Lattre and others added 20 commits April 3, 2024 11:03

Launchpad automatic translations update.

708905f

[MIG] account_banking_sepa_direct_debit: Migration to 8.0

a7b91fe

replace old sdd.mandate referencess

8a151b9

sepa direct debit: get BIC from bank account if not available on bank

1844385

Use attachments instead of creating a specific object for each kind o…

1d535f2

…f payment order

Add requested descriptions in an OCA README.rst file

d435cb2

account_banking_sepa_direct_debit: Fix error in payment order validat…

0f10f3e

…ion when there is more than one line with the same mandate.

[IMP] account_banking_sepa_direct_debit: Short headers + Bump version…

970c2ea

… numbers + es translations

Define SEPA identifiers per payment mode

692cb05

account_banking_sepa_direct_debit: Fixes OCA#257

0590f28

sepa_direct_debit_mandate: Split basic and sepa mandate

9646329

OCA Transbot updated translations from Transifex

77b6c16

[MIG] account_banking_sepa_direct_debit: Migration to 9.0

4112826

[FIX+IMP] account_banking_sepa_direct_debit: 3 things:

413fec1

* Remove unused POT files * Spanish translation * Fix mandate report layout

OCA Transbot updated translations from Transifex

df372d8

Ivorra78 and others added 10 commits April 3, 2024 11:03

[BOT] post-merge updates

b582d36

[16.0][IMP] account_banking_sepa_direct_debit: Button send mandate pe…

d9ce71f

…r email

[UPD] Update account_banking_sepa_direct_debit.pot

fe0a4f0

[BOT] post-merge updates

9d63609

[IMP] account_banking_sepa_direct_debit: black, isort, prettier

1e64ef8

JasminSForgeFlow force-pushed the 17.0-mig-account_banking_sepa_direct_debit branch from 5183f50 to 16f88c8 Compare April 3, 2024 06:02

[MIG] account_banking_sepa_direct_debit: Migration to 17.0

5b3d11f

JasminSForgeFlow force-pushed the 17.0-mig-account_banking_sepa_direct_debit branch from 16f88c8 to 5b3d11f Compare April 3, 2024 06:09

HaraldPanten approved these changes Apr 12, 2024

View reviewed changes

pedrobaeza reviewed Apr 13, 2024

View reviewed changes

pedrobaeza approved these changes Apr 15, 2024

View reviewed changes

OCA-git-bot added approved ready to merge labels Apr 15, 2024

OCA-git-bot added the bot is merging ⏳ label Apr 15, 2024

OCA-git-bot merged commit dc53e9e into OCA:17.0 Apr 15, 2024

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 15, 2024

MiquelRForgeFlow deleted the 17.0-mig-account_banking_sepa_direct_debit branch April 15, 2024 08:33

Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025

build(oca/17): OCA/bank-payment#1239

70a4b1a

TA23146

Uh oh!

[17.0][MIG] account_banking_sepa_direct_debit #1239

[17.0][MIG] account_banking_sepa_direct_debit #1239

Uh oh!

Conversation

JasminSForgeFlow commented Mar 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

HaraldPanten commented Mar 23, 2024

Uh oh!

HaraldPanten commented Mar 28, 2024

Uh oh!

pedrobaeza commented Apr 1, 2024

Uh oh!

HaraldPanten commented Apr 2, 2024

Uh oh!

OCA-git-bot commented Apr 2, 2024

Uh oh!

HaraldPanten commented Apr 2, 2024

Uh oh!

JasminSForgeFlow commented Apr 3, 2024

Uh oh!

JasminSForgeFlow commented Apr 3, 2024

Uh oh!

HaraldPanten commented Apr 12, 2024

Uh oh!

pedrobaeza Apr 13, 2024

Choose a reason for hiding this comment

Uh oh!

JasminSForgeFlow Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 15, 2024

Uh oh!

OCA-git-bot commented Apr 15, 2024

Uh oh!

OCA-git-bot commented Apr 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

36 participants

JasminSForgeFlow commented Mar 18, 2024 •

edited

Loading