[FIX][17.0] account_payment_order: Fix dynamic domain #1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramiadavid
force-pushed
the
17.0-fix-account_payment_order
branch
from
4b86b4e to
eaafa56
Compare
|
@pedrobaeza I have detected this problem that I did not detect when I migrated the module. I create this PR to solve it. |
pedrobaeza
reviewed
Apr 9, 2024
ramiadavid
force-pushed
the
17.0-fix-account_payment_order
branch
2 times, most recently
from
4dfc625 to
2503dc5
Compare
Return domain on onchange is deprecated in v17 Created computed Binary field to store domain
ramiadavid
force-pushed
the
17.0-fix-account_payment_order
branch
from
2503dc5 to
814b2ec
Compare
pedrobaeza
approved these changes
Apr 10, 2024
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 2a53509. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return domain in onchange is deprecated in v17 and does not work. A calculated Json field was created to store the domain.