[16.0][FIX] account_payment_order_vendor_email, write template with sudo #1302
Conversation
| partner_email_id = payment.partner_id.email | ||
| if partner_email_id: | ||
| template.write({"email_to": partner_email_id}) | ||
| template.sudo().write({"email_to": partner_email_id}) |
There was a problem hiding this comment.
Wait, why does this need to update the email on the template ?
There was a problem hiding this comment.
you're right @sbidoul
your ide @ChrisOForgeFlow ?
|
I'm not pretty sure why was design in that manner, For now I'm trying to
solve issue, but I will figure out if there is a better way to do it
…On Fri, Aug 16, 2024, 2:55 PM Florent THOMAS ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In account_payment_order_vendor_email/models/account_payment_mode.py
<#1302 (comment)>:
> @@ -73,7 +73,7 @@ def send_vendor_email(self):
)
partner_email_id = payment.partner_id.email
if partner_email_id:
- template.write({"email_to": partner_email_id})
+ template.sudo().write({"email_to": partner_email_id})
you're right @sbidoul <https://github.com/sbidoul>
your ide @ChrisOForgeFlow <https://github.com/ChrisOForgeFlow> ?
—
Reply to this email directly, view it on GitHub
<#1302 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWTY2ACWXU2WNLN3362L3F3ZRZKLPAVCNFSM6AAAAABKCPPGGCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBTGQ2TONRXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Hi @ursais, |
github-actions
bot
removed
the
stale
|
Hi @ursais ! |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
6 participants
Avoid need of template modify permission, to continue process