[16.0][FIX] account_payment_order_vendor_email, write template with sudo #1302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbidoul
reviewed
Aug 14, 2024
| @@ -73,7 +73,7 @@ def send_vendor_email(self): | |||
| ) | |||
| partner_email_id = payment.partner_id.email | |||
| if partner_email_id: | |||
| template.write({"email_to": partner_email_id}) | |||
| template.sudo().write({"email_to": partner_email_id}) | |||
There was a problem hiding this comment.
Wait, why does this need to update the email on the template ?
There was a problem hiding this comment.
you're right @sbidoul
your ide @ChrisOForgeFlow ?
|
I'm not pretty sure why was design in that manner, For now I'm trying to
solve issue, but I will figure out if there is a better way to do it
…On Fri, Aug 16, 2024, 2:55 PM Florent THOMAS ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In account_payment_order_vendor_email/models/account_payment_mode.py
<#1302 (comment)>:
> @@ -73,7 +73,7 @@ def send_vendor_email(self):
)
partner_email_id = payment.partner_id.email
if partner_email_id:
- template.write({"email_to": partner_email_id})
+ template.sudo().write({"email_to": partner_email_id})
you're right @sbidoul <https://github.com/sbidoul>
your ide @ChrisOForgeFlow <https://github.com/ChrisOForgeFlow> ?
—
Reply to this email directly, view it on GitHub
<#1302 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWTY2ACWXU2WNLN3362L3F3ZRZKLPAVCNFSM6AAAAABKCPPGGCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENBTGQ2TONRXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
Hi @ursais, |
github-actions
bot
removed
the
stale
|
Hi @ursais ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid need of template modify permission, to continue process