-
-
Notifications
You must be signed in to change notification settings - Fork 577
[17.0][FIX] account_payment_mode: error when payment mode #1312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][FIX] account_payment_mode: error when payment mode #1312
Conversation
|
Please give more context. |
Hello @pedrobaeza Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM code review
|
This PR has the |
a5122db to
a5d70d6
Compare
a5d70d6 to
68de5e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge patch
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 5c35040. Thanks a lot for contributing to OCA. ❤️ |
When installing
account_payment_modeand a provider together, we have an error linked to a duplicate payment method :#977
This error is linked to
account_payment_modeand it was considered fixed here: #1093 but the problem is still there: #1283But now odoo is checking by
account.payment.methodmodeuniqueorelectronic, so both need to be "unique".odoo/odoo@d07a696
So here I'm adapting the code to follow this logic.
I've found this PR for v16.0 (#1298) and I really don't know the best solution.