-
-
Notifications
You must be signed in to change notification settings - Fork 552
[16.0][MIG] account_payment_mode_default_account: Migration to 16.0 #1358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
[16.0][MIG] account_payment_mode_default_account: Migration to 16.0 #1358
Conversation
c6bf5b9
to
f62067f
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
property_stored_account_receivable_id = fields.Many2one( | ||
"account.account", | ||
company_dependent=True, | ||
string="Account Receivable", | ||
domain="[('internal_type', '=', 'receivable'), ('deprecated', '=', False), ('company_id', '=', current_company_id)]", # noqa | ||
) | ||
|
||
property_account_payable_id = fields.Many2one( | ||
company_dependent=False, | ||
compute="_compute_property_account_payable_id", | ||
inverse="_inverse_property_account_payable_id", | ||
) | ||
|
||
property_stored_account_payable_id = fields.Many2one( | ||
"account.account", | ||
company_dependent=True, | ||
string="Account Payable", | ||
domain="[('internal_type', '=', 'payable'), ('deprecated', '=', False), ('company_id', '=', current_company_id)]", # noqa | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LauraCForgeFlow I have this warning:
Two fields (property_stored_account_receivable_id, property_account_receivable_id) of res.users() have the same label: Account Receivable
Two fields (property_stored_account_payable_id, property_account_payable_id) of res.users() have the same label: Account Payable.
Maybe we could change the string to something different? Like Account Receivable Stored and Account Payable Stored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I changed the string to avoid this problem. Thanks! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that warning, functional and code review are okay!
Currently translated at 100.0% (17 of 17 strings) Translation: bank-payment-14.0/bank-payment-14.0-account_payment_mode_default_account Translate-URL: https://translation.odoo-community.org/projects/bank-payment-14-0/bank-payment-14-0-account_payment_mode_default_account/es/
f62067f
to
faec591
Compare
No description provided.