-
-
Notifications
You must be signed in to change notification settings - Fork 548
[18.0][MIG] account_payment_sale #1386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
- account_payment_partner - account_payment_sale - account_payment_sale_stock - account_payment_purchase Filter the selection of invoices per payment type. Add active field on payment.mode and payment.mode.type. Add menu entry for Payment Types.
* Migration and enhancement of all modules involved in SEPA * Remove duplicated files * Check if payment mode is set in the propagation * Clean files * account_payment_sale_stock: Split for removing stock dependency on sale * Remove old translations templates * Reorder on folder structure * Translation template files * Translations to spanish * Use sale_ok and purchase_ok instead of tweaking payment type * Add sale_ok and purchase_ok filters in partner/sale/purchase form views * Use widget=selection for payment_mode_id fields * Update demo data
Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug #300)
…d from a call to sale.action_invoice_create Into the normal process of the invoice creation from a sale order by odoo, the onchange_partner is called. In some case, this call will reset the specific payment_mode and/or partner_bank_id set on the sale_order. To fix this issue, we must override the _finalize_invoices method, take a snapshot of these values before the call to super and restore these values if these are changed. fixes #536
…irect_debit Steps to reproduce the problem: - Set a payment mode with fixed journal and set the journal with bank account A. - Create a sales order and put bank account B. - Create invoice. - Bank account in invoice is A instead of B.
The expected one is to not have partner bank set, as we don't want the invoice is printed with such bank account forced.
Remove inherit of sale.advance.payment.inv: no need to inherit _prepare_invoice_values() because it calls _prepare_invoice() from the sale.order object
Currently translated at 100.0% (4 of 4 strings) Translation: bank-payment-17.0/bank-payment-17.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_sale/it/
Currently translated at 100.0% (4 of 4 strings) Translation: bank-payment-17.0/bank-payment-17.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_sale/it/
Currently translated at 100.0% (4 of 4 strings) Translation: bank-payment-17.0/bank-payment-17.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_sale/pt_BR/
Currently translated at 100.0% (4 of 4 strings) Translation: bank-payment-17.0/bank-payment-17.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_sale/ca/
Currently translated at 100.0% (4 of 4 strings) Translation: bank-payment-17.0/bank-payment-17.0-account_payment_sale Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_sale/sv/
For avoiding the warning.
- Create setUpClass method - Include context keys for avoiding mail operations overhead.
Hi @alexis-via |
class SaleOrder(models.Model): | ||
_inherit = "sale.order" | ||
|
||
payment_method_line_id = fields.Many2one( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change of model would need a computation script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course !
Now depend on account_payment_base_oca
269e06e
to
f23c452
Compare
Hi @alexis-via! |
@eugenios73 Yep. It will depend on the result of the debate that you can follow here: https://odoo-community.org/groups/contributors-15/contributors-2029602 |
I think the debate is clear already: what is merged here in this repo is the plain migration, and in fact, the module is already merged: https://github.com/OCA/bank-payment/tree/18.0/account_payment_sale. |
Arf ! No comment... |
I'll publish the PR for account_payment_base_oca