Skip to content

[IMP][account_payment_order] Add Transmit Invoices filter #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[IMP][account_payment_order] Add Transmit Invoices filter #1431

wants to merge 1 commit into from

Conversation

vehi-invitu
Copy link

cc @cvinh

@vehi-invitu vehi-invitu force-pushed the 17.0-add_transmit_invoices_filter branch 2 times, most recently from d88f524 to 3bb216e Compare March 14, 2025 01:06
cvinh
cvinh suggested changes Mar 14, 2025
View reviewed changes
Copy link

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR.
IMHO, it's better to filter invoices that has NOT been part of a payment order instead of invoices that has been paid.

cvinh
cvinh reviewed Mar 14, 2025
View reviewed changes
@vehi-invitu vehi-invitu force-pushed the 17.0-add_transmit_invoices_filter branch from 3bb216e to 6c07e75 Compare March 14, 2025 22:44
cvinh
cvinh suggested changes Mar 22, 2025
View reviewed changes
Copy link

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be transmitted invoices instead of transmit invoices
Please check it

@vehi-invitu vehi-invitu force-pushed the 17.0-add_transmit_invoices_filter branch from 6c07e75 to 8c78069 Compare March 24, 2025 20:43
cvinh
cvinh approved these changes Mar 25, 2025
View reviewed changes
Copy link

@cvinh cvinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@cvinh
Copy link

cvinh commented May 31, 2025

@vehi-invitu can you rebase please ? runboat is stuck

@vehi-invitu vehi-invitu force-pushed the 17.0-add_transmit_invoices_filter branch from 8c78069 to 8b1bfdb Compare June 5, 2025 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvinh cvinh cvinh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vehi-invitu @cvinh