Skip to content

[17.0][FIX/IMP] account_payment_order: use payment_reference if present for out payments #1435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[17.0][FIX/IMP] account_payment_order: use payment_reference if present for out payments #1435

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion account_payment_order/models/account_move.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def _get_payment_order_communication_direct(self):
communication = self.payment_reference or self.ref or self.name
if self.is_invoice():
if self.is_purchase_document():
communication = self.ref or self.payment_reference
communication = self.payment_reference or self.ref
else:
communication = self.payment_reference or self.name
return communication or ""
Expand Down
21 changes: 16 additions & 5 deletions account_payment_order/tests/test_payment_order_outbound.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,13 @@ def test_invoice_communication_01(self):
)

def test_invoice_communication_02(self):
self.invoice.payment_reference = "R1234"
self.assertEqual(
"F1242", self.invoice._get_payment_order_communication_direct()
)
self.invoice.payment_reference = "R1234"
self.assertEqual(
"R1234", self.invoice._get_payment_order_communication_direct()
)

def test_invoice_communication_03(self):
self.invoice.ref = False
Expand All @@ -304,6 +307,13 @@ def test_invoice_communication_03(self):
self.invoice._get_payment_order_communication_full(),
)

def test_supplier_invoice_payment_reference(self):
self.invoice.payment_reference = "+++F1234+++"
self.invoice.action_post()
self.assertEqual(
"+++F1234+++", self.invoice._get_payment_order_communication_full()
)

def test_manual_line_and_manual_date(self):
# Create payment order
outbound_order = self.env["account.payment.order"].create(
Expand Down Expand Up @@ -406,7 +416,7 @@ def test_supplier_refund_reference(self):
self.invoice.payment_reference = "F/1234"
self.invoice.action_post()
self.assertEqual(
"F1242", self.invoice._get_payment_order_communication_direct()
"F/1234", self.invoice._get_payment_order_communication_direct()
)
self.refund = self._create_supplier_refund(self.invoice)
with Form(self.refund) as refund_form:
Expand All @@ -416,7 +426,9 @@ def test_supplier_refund_reference(self):
line_form.price_unit = 75.0

self.refund.action_post()
self.assertEqual("R1234", self.refund._get_payment_order_communication_direct())
self.assertEqual(
"FR/1234", self.refund._get_payment_order_communication_direct()
)

self.env["account.invoice.payment.line.multi"].with_context(
active_model="account.move", active_ids=self.invoice.ids
Expand All @@ -429,8 +441,7 @@ def test_supplier_refund_reference(self):

self.assertEqual(len(payment_order.payment_line_ids), 1)

self.assertEqual("F1242 R1234", payment_order.payment_line_ids.communication)
self.assertNotIn("FR/1234", payment_order.payment_line_ids.communication)
self.assertEqual("F/1234 FR/1234", payment_order.payment_line_ids.communication)

def test_supplier_manual_refund(self):
"""
Expand Down