[18.0][MIG] account_payment_order_return #1436

JasminSForgeFlow · 2025-03-25T05:01:09Z

Standard Migration

Depends on:

AndreuOForgeFlow

Minor change 👍 . I'd also add in a separate commit the reference to the dependency at OCA/account-payment#792, as seen here in the documentation: https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

AndreuOForgeFlow · 2025-05-05T10:34:22Z

account_payment_order_return/tests/test_account_payment_order_return.py

+                    (4, self.invoice.journal_id.id),
+                ],
+                "partner_ids": [(4, self.partner_a.id)],
+                "allow_blocked": True,


Suggested change

"allow_blocked": True,

This field was removed in the migration of the dependency account_payment_order, here: 43c010f

Done, Thanks

AndreuOForgeFlow · 2025-05-13T06:26:53Z

Hi @JasminSForgeFlow, in order to make testing possible, please add the dependency (account-payment/#792) in the test-requirements in a separate commit, as described in https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

JasminSForgeFlow · 2025-05-13T11:42:12Z

Hi @JasminSForgeFlow, in order to make testing possible, please add the dependency (account-payment/#792) in the test-requirements in a separate commit, as described in https://github.com/OCA/maintainer-tools/wiki/Use-temporary-reference%28s%29-to-another-pull-request%28s%29

Done, thanks

AndreuOForgeFlow

LGTM!

AndreuOForgeFlow · 2025-06-05T11:21:46Z

test-requirements.txt

@@ -0,0 +1 @@
+odoo-addon-account_payment_return@git+https://github.com/OCA/account-payment.git@refs/pull/792/head#subdirectory=account_payment_return


Suggested change

odoo-addon-account_payment_return@git+https://github.com/OCA/account-payment.git@refs/pull/792/head#subdirectory=account_payment_return

odoo-addon-account_payment_return@git+https://github.com/OCA/account-payment.git@refs/pull/833/head#subdirectory=account_payment_return

Hi @JasminSForgeFlow. It seems that this is the dependency (OCA/account-payment#833) that's active now. The other PR is closed.

Updated, Thanks

AndreuOForgeFlow · 2025-08-07T13:36:58Z

Hi @JasminSForgeFlow, I see that account_payment_return is merged now. You can now rebase and remove the commit [DON'T MERGE] test-requirements.txt, so that all the tests can be in green

JasminSForgeFlow · 2025-08-08T05:08:32Z

Hi @JasminSForgeFlow, I see that account_payment_return is merged now. You can now rebase and remove the commit [DON'T MERGE] test-requirements.txt, so that all the tests can be in green

Done, Thanks

:100644 100644 d46b131 a23b471 M account_payment_order_return/README.rst :100644 100644 340d1c7 1235bcb M account_payment_order_return/__manifest__.py :100644 100644 a341cc9 be7d7bb M account_payment_order_return/i18n/account_payment_order_return.pot :100644 100644 60be6ab e6b32b3 M account_payment_order_return/readme/CONTRIBUTORS.rst :100644 100644 a8591d0 826c26d M account_payment_order_return/readme/USAGE.rst :100644 100644 450f2d9 a5f5d97 M account_payment_order_return/static/description/index.html

fix domain in payment_order_return in order to avoid problems with moves without associated invoice as discused at OCA#718

TT27858

…revent error

TT28728

Don't post the invoice if it is already posted. See odoo/odoo@80c2818

When the test hour is around midnight, and demo data using CET/CEST timezones, current code fails due to some asserts not having this into consideration. This fix avoids such problem, and irons the execution no matter the hour.

- Include context keys for avoiding mail operations overhead.

Currently translated at 100.0% (2 of 2 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_payment_order_return Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_payment_order_return/it/

carlos-lopez-tecnativa · 2025-10-23T12:55:33Z

account_payment_order_return/tests/test_account_payment_order_return.py

+        cls.env = cls.env(
+            context=dict(
+                cls.env.context,
+                mail_create_nolog=True,
+                mail_create_nosubscribe=True,
+                mail_notrack=True,
+                no_reset_password=True,
+                tracking_disable=True,
+            )
+        )


Please import this from https://github.com/odoo/odoo/blob/de678f78869d6eec894f36662e19c2bae1355610/odoo/addons/base/tests/common.py#L11C1-L11C22

from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT

carlos-lopez-tecnativa · 2025-10-23T12:57:13Z

account_payment_order_return/tests/test_account_payment_order_return.py

+                "invoice_line_ids": [
+                    (
+                        0,
+                        0,
+                        {
+                            "product_id": cls.product_a.id,
+                            "price_unit": 1000.0,
+                            "tax_ids": [],
+                        },
+                    )
+                ],


Suggested change

"invoice_line_ids": [

(

0,

0,

{

"product_id": cls.product_a.id,

"price_unit": 1000.0,

"tax_ids": [],

},

)

],

"invoice_line_ids": [

Command.create(

{

"product_id": cls.product_a.id,

"price_unit": 1000.0,

"tax_ids": [],

},

)

],

I implemented your suggestions @carlos-lopez-tecnativa. Thanks for the review! :)

carlos-lopez-tecnativa

LGTM
TT54089
@pedrobaeza could you please review this?

OCA-git-bot · 2025-10-23T16:25:10Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza

18.0 migration diff reviewed.

/ocabot migration account_payment_order_return
/ocabot merge nobump

OCA-git-bot · 2025-10-23T16:26:12Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-1436-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2025-10-23T16:33:17Z

Congratulations, your PR was merged at 2af41f0. Thanks a lot for contributing to OCA. ❤️

AndreuOForgeFlow suggested changes May 5, 2025

View reviewed changes

JasminSForgeFlow force-pushed the 18.0-mig-account_payment_order_return branch from 02a0869 to fac3a87 Compare May 13, 2025 03:46

JasminSForgeFlow force-pushed the 18.0-mig-account_payment_order_return branch from 9409119 to 72cf94c Compare May 13, 2025 11:40

AndreuOForgeFlow approved these changes May 14, 2025

View reviewed changes

AndreuOForgeFlow suggested changes Jun 5, 2025

View reviewed changes

JasminSForgeFlow force-pushed the 18.0-mig-account_payment_order_return branch from 72cf94c to 67ad6f1 Compare June 20, 2025 03:57

AndreuOForgeFlow approved these changes Jun 30, 2025

View reviewed changes

JasminSForgeFlow force-pushed the 18.0-mig-account_payment_order_return branch from 67ad6f1 to 62da763 Compare August 8, 2025 05:08

Luis M. Ontalba and others added 18 commits October 23, 2025 10:29

[ADD] account_payment_order_return (OCA#395)

0657763

[MIG] account_payment_order_return: Migration to 11.0

8846d6a

fix domain in payment_order_return

18229e3

fix domain in payment_order_return in order to avoid problems with moves without associated invoice as discused at OCA#718

[IMP] account_payment_order_return: black, isort, prettier

0d208c7

[MIG] account_payment_order_return: Migration to 13.0

275a302

TT27858

[FIX] account_payment_order_return: Set correct journal in tests to p…

f2188af

…revent error

[FIX] account_payment_order_return: Fix tests

7cfaa4b

[MIG] account_payment_order_return: Migration to 14.0

ad311e2

TT28728

[FIX] account_payment_order_return: Fix tests

3b13f35

Don't post the invoice if it is already posted. See odoo/odoo@80c2818

account_payment_order_return 14.0.1.0.1

e11f613

[FIX] account_payment_order_return: Don't fail due to tz

dae611c

When the test hour is around midnight, and demo data using CET/CEST timezones, current code fails due to some asserts not having this into consideration. This fix avoids such problem, and irons the execution no matter the hour.

[MIG][15.0]account_payment_order_return:Migration to 15.0

bb06225

[IMP] account_payment_order_return: test performance improvement

703ab4e

- Include context keys for avoiding mail operations overhead.

[BOT] post-merge updates

1d41a96

[MIG] account_payment_order_return: Migration to 16.0

00d0747

[BOT] post-merge updates

4950683

Added translation using Weblate (Italian)

d391240

mymage and others added 2 commits October 23, 2025 10:29

[IMP] account_payment_order_return: black, isort, prettier

080bfff

LauraCForgeFlow force-pushed the 18.0-mig-account_payment_order_return branch from 62da763 to a632115 Compare October 23, 2025 08:29

carlos-lopez-tecnativa mentioned this pull request Oct 23, 2025

[18.0][MIG] account_payment_order_return #1514

Closed

carlos-lopez-tecnativa suggested changes Oct 23, 2025

View reviewed changes

[MIG] account_payment_order_return: Migration to 18.0

d482412

LauraCForgeFlow force-pushed the 18.0-mig-account_payment_order_return branch from a632115 to d482412 Compare October 23, 2025 14:14

carlos-lopez-tecnativa approved these changes Oct 23, 2025

View reviewed changes

OCA-git-bot added approved ready to merge labels Oct 23, 2025

pedrobaeza approved these changes Oct 23, 2025

View reviewed changes

OCA-git-bot added this to the 18.0 milestone Oct 23, 2025

OCA-git-bot added the bot is merging ⏳ label Oct 23, 2025

OCA-git-bot mentioned this pull request Oct 23, 2025

Migration to version 18.0 #1364

Open

19 tasks

OCA-git-bot merged commit fb95e36 into OCA:18.0 Oct 23, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Oct 23, 2025

		@@ -0,0 +1 @@
		odoo-addon-account_payment_return@git+https://github.com/OCA/account-payment.git@refs/pull/792/head#subdirectory=account_payment_return

Uh oh!

[18.0][MIG] account_payment_order_return #1436

[18.0][MIG] account_payment_order_return #1436

Uh oh!

Conversation

JasminSForgeFlow commented Mar 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AndreuOForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

AndreuOForgeFlow May 5, 2025

Choose a reason for hiding this comment

Uh oh!

JasminSForgeFlow May 13, 2025

Choose a reason for hiding this comment

Uh oh!

AndreuOForgeFlow commented May 13, 2025

Uh oh!

JasminSForgeFlow commented May 13, 2025

Uh oh!

AndreuOForgeFlow left a comment

Choose a reason for hiding this comment

Uh oh!

AndreuOForgeFlow Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

JasminSForgeFlow Jun 20, 2025

Choose a reason for hiding this comment

Uh oh!

AndreuOForgeFlow commented Aug 7, 2025

Uh oh!

JasminSForgeFlow commented Aug 8, 2025

Uh oh!

carlos-lopez-tecnativa Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

carlos-lopez-tecnativa Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

LauraCForgeFlow Oct 23, 2025

Choose a reason for hiding this comment

Uh oh!

carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Oct 23, 2025

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Oct 23, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

JasminSForgeFlow commented Mar 25, 2025 •

edited

Loading