Skip to content

[18.0][MIG] account_banking_mandate_sale: Migration to 18.0 #1456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: 18.0
Choose a base branch
from

Conversation

eugenios73
Copy link
Contributor

@eugenios73 eugenios73 commented Apr 29, 2025

Migration account_banking_mandate_sale 17.0 to 18.0

Superseed #1411

@eugenios73 eugenios73 changed the title 18.0 mig account banking mandate sale [18.0][MIG] account_banking_mandate_sale Migration to 18.0 Apr 29, 2025
@eugenios73 eugenios73 changed the title [18.0][MIG] account_banking_mandate_sale Migration to 18.0 18.0 mig account_banking_mandate_sale Apr 30, 2025
@eugenios73 eugenios73 changed the title 18.0 mig account_banking_mandate_sale [18.0][MIG] account_banking_mandate_sale. Migration to 18 Apr 30, 2025
@eugenios73 eugenios73 changed the title [18.0][MIG] account_banking_mandate_sale. Migration to 18 [MIG] account_banking_mandate_sale: Migration to 18.0 May 5, 2025
@eugenios73 eugenios73 changed the title [MIG] account_banking_mandate_sale: Migration to 18.0 [18.0][MIG] account_banking_mandate_sale: Migration to 18.0 May 5, 2025
Copy link
Contributor

@xaviedoanhduy xaviedoanhduy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, thanks for the works!

but could you check this WARNING? It happens when I am assigning value to mandate_id field on Sale Order form

025-05-15 11:46:10,419 958395 WARNING v18e_account_banking_mandate_sale odoo.models: Cannot search on display_name, no _rec_name or _rec_names_search defined on account.banking.mandate

image

@eugenios73
Copy link
Contributor Author

eugenios73 commented May 19, 2025

account_banking_mandate_sale odoo.models: Cannot search on display_name, no _rec_name or _rec_names_search defined on account.banking.mandate

Hello @xaviedoanhduy , thanks for your review.

I've reviewed the warning. Apparently, in the account.banking.mandate model of the account_banking_mandate module, two fields are missing: _rec_name and _rec_names_search. These fields allow searching for records in Many2one fields. To fix this correctly, the best approach is to add both attributes directly to the base module with a small correction, rather than doing it through a migration from another module.

I have fixed this warning in the following PR: #1472

Copy link
Contributor

@xaviedoanhduy xaviedoanhduy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts and it looks good to me

@eugenios73 eugenios73 force-pushed the 18.0-mig-account_banking_mandate_sale branch from ace8dec to 6ada35d Compare May 20, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants