[18.0][FIX] account_banking_sepa_direct_debit: generation of 'Instruction Identification' and 'End to End Identification' #1475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dentification' and 'End to End Identification' In Odoo v18, a draft account.payment don't have a move_id. So payment.move_id.id is False when generating the payment file (the account.payment are confirmed when going from 'generated' to 'uploaded'). So we can't use payment.move_id.id to generate 'Instruction Identification' and 'End to End Identification' in the generation of the SEPA XML file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEFORE
AFTER
In Odoo v18, a draft account.payment don't have a move_id. So payment.move_id.id is False when generating the payment file (the account.payment are confirmed when going from 'generated' to 'uploaded'). So we can't use payment.move_id.id to generate 'Instruction Identification' and 'End to End Identification' in the generation of the SEPA XML file.
BTW, I don't think using the ID of the move or the ID of the account.payment in the identification tags of the SEPA XML file is a good practise... but that's another story. This change was introduced by the move to account.payment.
I found this bug while working on OCA/bank-payment-alternative... I'll fix it there too.