[19.0][MIG] account_payment_mode: Migration to 19.0 and Merged account_payment_partner into account_payment_mode. #1504
Conversation
There was a problem hiding this comment.
Functional review OK.
@OCA/banking-maintainers Wouldn't have sense to minimize the so many modules and leave it more compact? For example, in this case we have:
- account_payment_mode
- account_payment_partner
All modules depend on partner, not in mode, so, IMO, we could merge both modules in a single one. WDYT?
I leave open the decision of account_payment_order, as we are adding a strong dependency on other modules, but at the end, if you use account_payment_mode, you will be using account_payment_order, isn't it?
|
Merging account_payment_mode and account_payment_partner could make sense. But account_payment_order and related addons would add a lot of dependencies that should be in difierent modules, IMO. |
|
I was opening the idea just for order, not sepa modules. However, I agree that partner and mode is enough. @bizzappdev can you handle this? |
|
I agree with merging account_payment_mode and account_payment_partner 👍 |
|
This PR has the |
After analysing, I also agree. Now the question is, what should the module be called? Integrate everything into account_payment_partner and deprecate the account_payment_mode module, or create a new module and deprecate both modules? |
|
I would suggest to merge everything on account_payment_mode. For me specifies the goal of the module (create the payment mode) and the merge with partner is just a direct evolution of it. |
I agree merging both modules in account_payment_mode. |
bizzappdev
force-pushed
the
19.0-mig-account_payment_mode-BAD
branch
from
e4b7073 to
1749be2
Compare
- account_payment_partner - account_payment_sale - account_payment_sale_stock - account_payment_purchase Filter the selection of invoices per payment type. Add active field on payment.mode and payment.mode.type. Add menu entry for Payment Types.
* Migration and enhancement of all modules involved in SEPA * Clean files * Replace deprecated workflow calls * Translation template files * Translations to spanish * Use sale_ok and purchase_ok instead of tweaking payment type
* IMP: Add filter group by payment mode in account invoices * FIX: Remove deprecated tag type
* move unused file + cleanup code * Add sale_ok and purchase_ok filters in partner/sale/purchase form views * Use widget=selection for payment_mode_id fields * Update demo data * Return res in inherit (even if res is empty in this case)
…hout invoice (manual entries in receivables/payables)
FIX tabs FIX translate
* Forgot to remove a usecase of debit_denied * Add ACL * Better filters on payment.order.create wizard * Add default values for those filters on payment.mode * FIX remove coma at end of line * Add translatable 'label' field on payment.mode, designed to be used in invoice report
* Short headers * Remove label field There's already a field in the payment mode called 'note' that is printed on the invoices, so there's no need of another field for that purpose. This field is added by account_banking_payment_export * Bump version numbers * es translations * Name to filter for better inheratiblity
… a lot of improvements) during the Sorrento Code sprint 2016 Improvements include: - full re-organisation of modules and big re-organisation of the code - simplification of the code related to the fact that support for direct debit is now in t he base module, not added by an optional module account_direct_debit (module was removed) - new design of the wizard to select move lines to pay - support for non-SEPA file transfer- - support for German direct debit SEPA files (fixes bug OCA#129) - remove workflow of payment.order * Finalise the wizard of selection of move lines to pay * Add button "Add to payment/debit order" on invoice form view * Started to integrate payment transfer in account_payment_order (not finished at all though) * Copy payment mode and mandate from invoice to refund * Run dos2unix on the few files that had DOS carriage return * Add _id suffix on M2O fields customer_payment_mode and supplier_payment_mode (Odoo did the same on all the M2O property fields of res.partner) * Better handling of partner_bank_id and mandate_id on invoice: invisible/required/onchange * Move field bank_account_required from module account_payment_partner to account_payment_mode
Currently translated at 64.5% (31 of 48 strings) Translation: bank-payment-16.0/bank-payment-16.0-account_payment_mode Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_payment_mode/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-16.0/bank-payment-16.0-account_payment_mode Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_payment_mode/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-17.0/bank-payment-17.0-account_payment_mode Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_mode/
Currently translated at 100.0% (47 of 47 strings) Translation: bank-payment-17.0/bank-payment-17.0-account_payment_mode Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_mode/sv/
For avoiding the warning.
Currently translated at 100.0% (47 of 47 strings) Translation: bank-payment-17.0/bank-payment-17.0-account_payment_mode Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_mode/it/
- Include context keys for avoiding mail operations overhead.
…dules have been installed
Currently translated at 100.0% (47 of 47 strings) Translation: bank-payment-18.0/bank-payment-18.0-account_payment_mode Translate-URL: https://translation.odoo-community.org/projects/bank-payment-18-0/bank-payment-18-0-account_payment_mode/it/
bizzappdev
force-pushed
the
19.0-mig-account_payment_mode-BAD
branch
from
1749be2 to
7a50ef9
Compare
bizzappdev
changed the title
| - Víctor Martínez | ||
| - [DynApps](https://www.dynapps.be): | ||
| - Raf Ven \<<[email protected]>\> | ||
| - Marçal Isern \<<[email protected]>Bert Van Groenendael\> |
There was a problem hiding this comment.
Marçal an Bert are two different people 😉
bizzappdev
force-pushed
the
19.0-mig-account_payment_mode-BAD
branch
from
7a50ef9 to
9d51577
Compare
…ent_partner into account_payment_mode.
bizzappdev
force-pushed
the
19.0-mig-account_payment_mode-BAD
branch
from
9d51577 to
e21d661
Compare
67 participants
Merged
account_payment_partnerintoaccount_payment_mode.