[16.0][IMP] account_banking_mandate_contact: Make field company-dependent #1513
Conversation
There was a problem hiding this comment.
I think it's necessary to update the code in the module account_banking_mandate_sale_contact to ensure that the field is taken from the company of the sale order, just like Odoo does https://github.com/odoo/odoo/blob/f86ebd3a1772dfd9b5b04062df2d58a1fcf1af79/addons/sale/models/sale_order.py#L369
Banking mandates, on contrary than the partner banks, have to be company specific, as the mandate is signed between the company and the partner, not for all the companies in Odoo. Thus, if we set a specific banking mandate for a contact, it should be restricted just to the company in which the mandate was signed. Let's make the field company dependent for avoiding the problem. TT58428
pedrobaeza
force-pushed
the
16.0-imp-account_banking_mandate_contact-company_dependent
branch
from
b38886c to
cbe03c0
Compare
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1513-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 37ed97c. Thanks a lot for contributing to OCA. ❤️ |
pedrobaeza
deleted the
16.0-imp-account_banking_mandate_contact-company_dependent
branch
4 participants
Banking mandates, on contrary than the partner banks, have to be company specific, as the mandate is signed between the company and the partner, not for all the companies in Odoo.
Thus, if we set a specific banking mandate for a contact, it should be restricted just to the company in which the mandate was signed.
Let's make the field company dependent for avoiding the problem.
@Tecnativa TT58428