Skip to content

[18.0][FIX] account_banking_mandate: Make partner bank domain to work #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
+11 −7
Merged

[18.0][FIX] account_banking_mandate: Make partner bank domain to work #1515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions account_banking_mandate/models/account_banking_mandate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,6 @@ class AccountBankingMandate(models.Model):
_check_company_auto = True
_rec_names_search = ["unique_mandate_reference", "partner_bank_id.acc_number"]

def _get_default_partner_bank_id_domain(self):
if "default_partner_id" in self.env.context:
return [("partner_id", "=", self.env.context.get("default_partner_id"))]
else:
return []

format = fields.Selection(
[("basic", "Basic Mandate")],
default="basic",
Expand All @@ -43,11 +37,11 @@ def _get_default_partner_bank_id_domain(self):
comodel_name="res.partner.bank",
string="Bank Account",
tracking=40,
domain=lambda self: self._get_default_partner_bank_id_domain(),
ondelete="restrict",
index="btree",
check_company=True,
)
partner_bank_domain = fields.Binary(compute="_compute_partner_bank_domain")
partner_id = fields.Many2one(
comodel_name="res.partner",
related="partner_bank_id.partner_id",
Expand Down Expand Up @@ -96,6 +90,15 @@ def _get_default_partner_bank_id_domain(self):
)
]

@api.depends("format") # A field with default for triggering the compute
@api.depends_context("default_partner_id")
def _compute_partner_bank_domain(self):
self.partner_bank_domain = []
if "default_partner_id" in self.env.context:
self.partner_bank_domain = [
("partner_id", "=", self.env.context["default_partner_id"])
]

@api.depends("unique_mandate_reference", "partner_bank_id.acc_number")
def _compute_display_name(self):
for mandate in self:
Expand Down
1 change: 1 addition & 0 deletions account_banking_mandate/views/account_banking_mandate_view.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@
<field
name="partner_bank_id"
options="{'create_name_field': 'acc_number'}"
domain="partner_bank_domain"
invisible="context.get('mandate_bank_partner_view')"
/>
<field
Expand Down