[IMP] account_payment_partner: Handle ir_property table rename in migrations #1516
+56
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rations In Odoo 18.0, the ir_property table was renamed to _ir_property. This adds a pre-migration to create a temporary copy for compatibility with openupgrade_180.convert_company_dependent(), and cleans it up in post-migration.
|
Hi @pedrobaeza What do you think of this solution? |
|
Sorry, but no. We are not going to handle enterprise specific code that dirties everything and make this less readable (or even to know if it's going to work). And it also has impact in the performance terms. Compare your solution with the current one: https://github.com/OCA/bank-payment/blob/18.0/account_payment_partner/migrations/18.0.1.0.0/post-migration.py Put that scripts in your side. |
|
I think your best bet is to rename the table |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Odoo 18.0, the ir_property table is renamed to _ir_property when using the Enterprise Migration Service. This adds a pre-migration to create a temporary copy for compatibility with openupgrade_180.convert_company_dependent(), and cleans it up in post-migration.
Related:
#1507
#1498
#1492