[MIG][14.0] account_banking_mandate #758
Conversation
* Bug OCA#96 bad use of new API * [Usability] mandates: search by reference, add group_by, add seq type in tree view * Add scheme in mandate tree+search view * Replace tabs by spaces in mandate views * account_banking_mandate/views/account_banking_mandate_view.xml: convert from dos to unix format * Add multi-company rule on account.banking.mandate
Fix an important regression in account_banking_sepa_direct_debit: "Date of Last Debit" was not set any more Proper write of date_done with account_banking_payment_export is installed without account_banking_payment_transfer Add post-install script for date_sent on payment.order
The restriction rule Banking Mandate multi-company, gives an error when editing a partner bank account from a company A when that account has created a mandate from another company B. So it is impossible to create a mandate for each company without disabling the rule. Solution: Uncheck the rule writte in Banking Mandate multi-company. But i'm not sure this is correct.
* Short headers * Bump version numbers * es translations
* Add creditor identifier field to report mandate. * Translate. * Split basic and sepa mandate * Use api.multi instead * Make format field required
Port almost all modules to v10 * Update to EPC Rulebook v9.2 that start to apply on 2016-11-20 (bug OCA#300)
…ovided Using same method as in upstream, mandate is filled on invoice creation if no one is provided. This way, we don't need to install account_banking_mandate_sale if we don't want to handle several mandates at sales level.
…ically on the payment line'
…date + Add valid_mandate field and fix onchange (cherry picked from commit 25d2e4d)
add tests and constrains
* Fix tests due to upstream change Odoo has added a constraint for avoiding a company currency change if there are move lines, making these tests to fail, as the currency is changed to EUR. With this commit, we create a new company with EUR currency for avoiding the problem. This commit also changes account_banking_mandate for not duplicating mandate number, as it was detected during the test creation. Similar to 1f8e345 * Avoid errors in tests when run with other modules * More adaptations to make tests to work properly All these problems comes from using demo data.
Currently translated at 100,0% (82 of 82 strings) Translation: bank-payment-11.0/bank-payment-11.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_banking_mandate/es/
Currently translated at 68,3% (56 of 82 strings) Translation: bank-payment-11.0/bank-payment-11.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-11-0/bank-payment-11-0-account_banking_mandate/ca/
Currently translated at 100.0% (101 of 101 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_banking_mandate/es_AR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: bank-payment-13.0/bank-payment-13.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_banking_mandate/
Currently translated at 100.0% (101 of 101 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_banking_mandate/es_AR/
Currently translated at 100.0% (101 of 101 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_banking_mandate/es_AR/
…ng some records with mandate
Currently translated at 64.4% (65 of 101 strings) Translation: bank-payment-13.0/bank-payment-13.0-account_banking_mandate Translate-URL: https://translation.odoo-community.org/projects/bank-payment-13-0/bank-payment-13-0-account_banking_mandate/nl/
Replace constrains on company by check_company=True on fields
|
Thanks for all your work in these module ports again! Can I take the opportunity of asking what the use is of having the mandate_id on the move line as well as on the move, especially if the move's mandate_id is propagated to the move line's mandate ids. Would it make more sense not to propagate them on |
|
@StefanRijnhart I agee with you, it's strange to have mandate_id on both move and move.line. I think we should have it on the move only, and re-organise the code to read it there. I'll do that in the coming days/weeks. |
|
Can you please check Travis? |
|
I think Travis was failing because |
|
Yes, restarted and now green. Please review. |
|
I can file a PR into this one for my suggestion if needed. |
There was a problem hiding this comment.
@alexis-via could you squash the two migration commits into one?
Also, please check the comments bellow.
Otherwise, looks good 👍
| # Copyright 2014-2020 Compassion CH - Cyril Sester <[email protected]> | ||
| # Copyright 2014-2020 Tecnativa - Pedro M. Baeza | ||
| # Copyright 2015-2020 Akretion - Alexis de Lattre <[email protected]> | ||
| # Copyright 2017-2020 Tecnativa - Carlos Dauden <[email protected]> |
There was a problem hiding this comment.
You do you change the Copyright from the previous changes? This should be left as is, and you should only add your Copyright with the current year
| # Copyright 2014-2020 Compassion CH - Cyril Sester <[email protected]> | ||
| # Copyright 2014-2020 Tecnativa - Pedro M. Baeza | ||
| # Copyright 2015-2020 Akretion - Alexis de Lattre <[email protected]> |
|
@StefanRijnhart that would be good for finishing this. |
|
I've created a draft #770. I've processed @joao-p-marques's comments so we can use it as a superseding PR unless @alexis-via disagrees. |
|
I think we can close this in favour of #770, as @alexis-via seems unresponsive. @pedrobaeza can you do it? |
27 participants
No description provided.