[14.0][FIX/IMP] account_payment_partner

[alexis-via]

FIX form view of account.move
Replace python constraint by check_company=True on payment_mode_id of account.move

[pedrobaeza]

Please check Travis

[StefanRijnhart]

Travis agrees that this change improves the consistency of the data :-)

Traceback (most recent call last):
  File "/home/travis/build/OCA/bank-payment/setup/account_payment_partner/odoo/addons/account_payment_partner/tests/test_account_payment_partner.py", line 297, in test_invoice_constrains
    "payment_mode_id": self.supplier_payment_mode_c2.id,
...
  File "/home/travis/OCB-14.0/odoo/models.py", line 3900, in create
    records._check_company()
  File "/home/travis/OCB-14.0/odoo/models.py", line 3321, in _check_company
    raise UserError("\n".join(lines))
odoo.exceptions.UserError: Incompatible companies on records:
- 'Draft Bill MISC/2020/12/0001' belongs to company 'YourCompany' and 'Payment Mode' (payment_mode_id: 'Suppliers Bank 2') elongs to another company.

[pedrobaeza]

No news on this?

[pedrobaeza]

@alexis-via are you going to fix this PR?

[alexis-via]

I updated the tests (raises UserError instead of ValidationError). The tests work on my laptop ; Travis should be green this time.

[pedrobaeza]

You are moving this to a place that is not always shown (I don't see it in customer invoices) and not in main section. Please put it before journal_id instead.

[alexis-via]

@pedrobaeza I don't understand your last remark. This is the view I have on customer invoices:

[pedrobaeza]

I don't see anything with your debug mode activated and overlapping the screenshot. Can you repeat it?

[alexis-via]

Sorry about this bad screenshot. Here is a better one

[pedrobaeza]

I'm not seeing "Recipient Bank" in runbot, but OK if it's always show in that position.

/ocabot merge minor

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-765-by-pedrobaeza-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 92c82e1. Thanks a lot for contributing to OCA. ❤️