Skip to content

Conversation

@Murtaza-OSI
Copy link

No description provided.

@max3903 max3903 added this to the 14.0 milestone Mar 7, 2021
@max3903 max3903 self-requested a review March 7, 2021 21:48
@max3903 max3903 self-assigned this Mar 7, 2021
@max3903 max3903 changed the title [ADD][14.0] account_payment_order_void_lines Module. [ADD] account_payment_order_void_lines Mar 7, 2021
@max3903
Copy link
Member

max3903 commented Mar 7, 2021

@Murtaza-OSI

<string>:1: (WARNING/2) Title overline too short.

=====================
Account Payment Order Void Lines
=====================
2021-03-07 21:40:42,461 218 WARNING odoodb odoo.addons.base.models.ir_module: docutils' system message present: <system_message level="2" line="1" source="<string>" type="WARNING"><paragraph>Title overline too short.</paragraph><literal_block xml:space="preserve">=====================
Account Payment Order Void Lines
=====================</literal_block></system_message>

@pedrobaeza
Copy link
Member

Please avoid plurals in module name.

@Chandresh-SerpentCS Chandresh-SerpentCS force-pushed the 14.0-MIG-account_payment_order_void_lines branch from 90d9a20 to 9b7ccbf Compare September 16, 2021 19:05
@Freni-OSI Freni-OSI force-pushed the 14.0-MIG-account_payment_order_void_lines branch from 9b7ccbf to d3a0d2a Compare October 27, 2021 11:44
@dreispt dreispt self-requested a review November 9, 2021 09:47
Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ ] Change module name to account_payment_order_void_lines
[ ] Add readme/ subdirectory with readme fragments

@dreispt dreispt changed the title [ADD] account_payment_order_void_lines [14.0][ADD] account_payment_order_void_lines Nov 9, 2021
@dreispt dreispt force-pushed the 14.0-MIG-account_payment_order_void_lines branch 2 times, most recently from d339a15 to 02ff8c4 Compare November 9, 2021 14:17
@dreispt dreispt self-requested a review November 9, 2021 14:18
@dreispt dreispt changed the title [14.0][ADD] account_payment_order_void_lines [14.0][ADD] account_payment_order_void_line Nov 9, 2021
@Murtaza-OSI Murtaza-OSI force-pushed the 14.0-MIG-account_payment_order_void_lines branch from 2b39587 to 5b42cb0 Compare November 23, 2021 07:55
Copy link
Member

@dreispt dreispt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the OSI icon, OCA modules can't be company branded.

@@ -0,0 +1 @@
This module is used to cancel the payment line.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How?
Can you describe the steps to use or test this?

@dreispt dreispt force-pushed the 14.0-MIG-account_payment_order_void_lines branch from c80bd94 to 32d09ab Compare November 15, 2022 11:34
@dreispt dreispt self-requested a review November 15, 2022 11:35
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 19, 2023
@github-actions github-actions bot closed this Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement needs fixing stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants