[14.0][IMP] account_payment_order #792
Conversation
max3903
force-pushed
the
14.0-imp-account_payment_order
branch
from
b0ec290 to
e194519
Compare
|
This PR has the |
| lambda x: x.move_line_id | ||
| and not x.move_line_id.reconciled | ||
| and x.move_line_id.account_id == line.account_id | ||
| and x.move_line_id.credit == line.debit |
There was a problem hiding this comment.
you cannot compare 2 floats with ==
| type="object" | ||
| states="uploaded" | ||
| string="Done Payments" | ||
| /> |
There was a problem hiding this comment.
What's the point of the "done" state ? It was not present in my initial design of account_payment_order, and I see that it has been introduced by @JordiBForgeFlow in this commit
81152bf
but the commit message gives no clue about the reason for this new "done" state. For me, the final state is "uploaded"... what's the added value of the done state?
Sorry if my question is stupid...
There was a problem hiding this comment.
I'm attempting to fix this soon along the lines of what previous versions did, see #784 (comment) - when done we can add this here too in another PR
There was a problem hiding this comment.
2021-11-09 14:34:02,634 28 INFO KEN_Master_V14_2021_09_23 odoo.addons.base.models.ir_ui_view: action_done is not a valid action on account.payment.order
View name: account.payment.order.form
Error context:
view: ir.ui.view(4540,)
xmlid: account_payment_order_form
view.model: account.payment.order
file: /opt/odoo/kentest14-odoo/src/odoo-platform/odoo/external-src/bank-payment/account_payment_order/views/account_payment_order.xml
Getting error with latest gitaggregate
|
|
||
| if self.payment_mode_id.offsetting_account == "bank_account": | ||
| account_id = self.journal_id.default_account_id.id | ||
| account_id = self.journal_id.payment_debit_account_id.id |
There was a problem hiding this comment.
you should make a difference between inbound and outbond : payment_debit_account_id and payment_credit_account_id
There was a problem hiding this comment.
Agree. @max3903 Could you update accordingly?
There was a problem hiding this comment.
@alexis-via That's a behaviour you partly removed here: https://github.com/OCA/bank-payment/pull/822/files#diff-f55b2fce8819072c65c79eaaf78564a96202ccca3de7a8be6f99c1c6862cb325L430
There was a problem hiding this comment.
Did it there : ursais#9
There was a problem hiding this comment.
Ok, I confirm this has already been solved in latest version. So, no need this change
|
Travis is red. |
|
Cannot use git-aggreagate, please resolve conflicts |
dreispt
force-pushed
the
14.0-imp-account_payment_order
branch
from
462cfa3 to
d08e591
Compare
|
...I rebased and solved conflicts. |
|
Thanks @dreispt |
|
And please provide a description of the "improvements". |
| type="object" | ||
| states="uploaded" | ||
| string="Done Payments" | ||
| /> |
There was a problem hiding this comment.
2021-11-09 14:34:02,634 28 INFO KEN_Master_V14_2021_09_23 odoo.addons.base.models.ir_ui_view: action_done is not a valid action on account.payment.order
View name: account.payment.order.form
Error context:
view: ir.ui.view(4540,)
xmlid: account_payment_order_form
view.model: account.payment.order
file: /opt/odoo/kentest14-odoo/src/odoo-platform/odoo/external-src/bank-payment/account_payment_order/views/account_payment_order.xml
Getting error with latest gitaggregate
|
For me, this PR is not relevant any more following the merge of my PR #822 a few days ago. It uses fields that don't exist any more... |
| else: | ||
| account_id = self.journal_id.payment_debit_account_id.id | ||
|
|
||
| if self.payment_mode_id.offsetting_account == "bank_account": |
There was a problem hiding this comment.
offsetting_account field is not available in https://github.com/ursais/bank-payment/blob/14.0-imp-account_payment_order/account_payment_order/models/account_payment_mode.py#L78, so we are getting error. Please check and make changes
It was removed in this commit(ursais@cbe1eed#diff-bc1e10412f0a69eab3d4e969864e38c2051ae55ee7a4f6fd10d1463e8ae9e72dL78)
cc: @SodexisTeam
13 participants
No description provided.