[IMP] brand - brand_use_level should make brand invisible if 'Do not use brands on business document'

[baimont]

In this commit @AntoniRomera adds

if self.env["res.brand"].check_access_rights("read", raise_exception=False):

I'm not sure why since we have access right res_brand_access_all that gives read access to everyone.

For migration to 18, this has been rewritten to

if self.env["res.brand"].check_access("read"):

This breaks the use of brand_use_level. Tested with demo or admin: we don't pass in that code anymore because check_access return None when you have access. Therefore we never go in the code inside _get_view of brand module. On the web interface, this leads to have the brand_id field always visible, even if in your configuration you say that you do not want to use brand on business document.

[OCA-git-bot]

Hi @sbejaoui,
some modules you are maintaining are being modified, check this out!

[marielejeune]

Indeed, the check access on "read" is useless and since it breaks the behavior in v18, let's drop it.