Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BKP] sale_commission_agent_restrict #368

Closed

Conversation

SirTakobi
Copy link

@SirTakobi SirTakobi changed the title [12.0][BKP] sale_commission_agent_restrict [BKP] sale_commission_agent_restrict Aug 29, 2022
@SirTakobi SirTakobi force-pushed the 12.0-bkp-sale_commission_agent_restrict branch 2 times, most recently from db6dc69 to 5d5f946 Compare August 29, 2022 12:11
@SirTakobi SirTakobi force-pushed the 12.0-bkp-sale_commission_agent_restrict branch from 5d5f946 to 39e59d6 Compare August 29, 2022 12:14
Rename agent_ids to agents
Rename agent_id to agent
Increase coverage
Hook is already executed as superuser
…compute_commission_total

Also, computed value cannot be stored because depends on current user
@SirTakobi SirTakobi force-pushed the 12.0-bkp-sale_commission_agent_restrict branch 2 times, most recently from 5792079 to 242d3fb Compare August 29, 2022 16:22
Agent can access its own partner, the partners it creates or the ones it is agent for
@SirTakobi SirTakobi force-pushed the 12.0-bkp-sale_commission_agent_restrict branch from a393fe4 to e664491 Compare August 30, 2022 07:45
@SirTakobi SirTakobi marked this pull request as ready for review August 31, 2022 15:44
@github-actions
Copy link

github-actions bot commented Jan 1, 2023

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 1, 2023
Copy link
Member

@eLBati eLBati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@github-actions github-actions bot closed this Feb 5, 2023
@SirTakobi
Copy link
Author

@OCA/crm-sales-marketing-maintainers why has this been closed? There was a review right after the bot message.
By the way, can someone have a look?
Thanks!

@eLBati
Copy link
Member

eLBati commented Oct 14, 2024

Moving to #567

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants