[17.0][IMP] commission repo - Add missing commits #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch invoice line column to Invoice name + Customer + Description + Amount for better comprehension. TT46914
|
Hi @pedrobaeza, |
|
TODO: Fix the tests for v17 |
sergio-teruel
force-pushed
the
17.0-FIX-account_commission-missing-commits
branch
from
3673ffd to
8569717
Compare
|
@sergio-teruel please incorporate the pre-commit and test fixes on each of the commits that provokes that problems. |
We should ensure that the partner's currency is the one in the company to avoid test integration issues TT38303
Not using Form() in tests can lead to some tricky integration tests issues. In this case, just overriding _recompute_payment_terms_lines with a new context in a third module wasn't making these true. TT47134
Place footer outside the table so that it won't be repeated at each page [LINT]use pre commit Revert bad linting [DEL]commission: useless clearfix Useless clearfix in XML reporting
…settle in only one settlement TT48574
That way, deletions of agent lines in invoices are faster.
sergio-teruel
force-pushed
the
17.0-FIX-account_commission-missing-commits
branch
from
8569717 to
f4d005b
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa
Missing commits from 16