Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] Bugs and improvements in subscription_oca #1057

Open
tarteo opened this issue Mar 13, 2024 · 3 comments
Open

[16.0] Bugs and improvements in subscription_oca #1057

tarteo opened this issue Mar 13, 2024 · 3 comments
Labels

Comments

@tarteo
Copy link
Member

tarteo commented Mar 13, 2024

Just wanted to check before I create a PR if some of these are as intended.

subscription.action_close_subscription()

This will not actually close the subscription just open the close reason wizard.

sale_subscription.active = False

Why do we archive the record here directly IMO closed subscription should be just in the closed stage not archived directly

in_progress = fields.Boolean(string="In progress", default=False)

This field is redundant because of field type.

else:
if subscription.date_start == today:
subscription.action_start_subscription()
subscription.generate_invoice()

This way we can't have "draft" subscriptions. There should by another stage before "pre".

subscription.recurring_next_date == today

If the cron job fails for a day subscription begin to stagnate, this should be <=

record.recurring_rule_boundary = True

This should be the otherway around if there is not a boundary (unlimited) this should be False not True. This is confusing.

Other:

  • The tests don't pass if sale_timesheet is installed.
  • Showing the billing period on the invoice would be nice.
@francesco-ooops
Copy link
Contributor

Hi @tarteo , I would suggest checking also all the IMPs and FIXs made to the v14 of the module: https://github.com/OCA/contract/pulls?q=is%3Apr+is%3Aclosed+subscription_oca

@gregory-moka
Copy link
Contributor

Hello
I add 1 more lack in the addon : On sale order, we are not able to define the subscription's start date.
Maybe we can detect if a product is a subscription product to display the start date field (by default, this start date is defined by confirmation date).

Another issue is linked to the access rules. For non-admin users, it's not possible to access to contact models once the addon is installed.

@tarteo
Copy link
Member Author

tarteo commented Aug 29, 2024

A sequence field on sale.subscription.line can also be useful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants