Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes to use mollie mandates instead of subscriptions for recurring payments #55

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Changes to use mollie mandates instead of subscriptions for recurring payments #55

merged 1 commit into from
Aug 21, 2024

Conversation

ByteMeAsap
Copy link
Contributor

No description provided.

@ByteMeAsap ByteMeAsap requested a review from tarteo July 4, 2024 13:19
@ByteMeAsap ByteMeAsap force-pushed the 16.0-update-sale_recurring_payment branch 2 times, most recently from b52641c to 7f63c83 Compare July 9, 2024 13:12
This was referenced Aug 9, 2024
Closed
Merged
tarteo
tarteo requested changes Aug 20, 2024
View reviewed changes
Copy link
Member

@tarteo tarteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of an direct payment on an invoice should we filter it also in this method _mollie_get_supported_methods ?

sale_recurring_payment/models/sale_subscription.py Outdated Show resolved Hide resolved
sale_recurring_payment/models/sale_subscription.py Outdated Show resolved Hide resolved
sale_recurring_payment_mollie/models/payment_transaction.py Show resolved Hide resolved
@ByteMeAsap ByteMeAsap force-pushed the 16.0-update-sale_recurring_payment branch from 7f63c83 to a91dd4a Compare August 21, 2024 05:56
@ByteMeAsap
Copy link
Contributor Author

In case of an direct payment on an invoice should we filter it also in this method _mollie_get_supported_methods ?

I think that's logical ,I have added it

@ByteMeAsap @tarteo
Changes to use mollie mandates instead of subscriptions for recurring…
da7c151 
… payments

pre-commit fixes

Updated name of module

Updates
@tarteo tarteo force-pushed the 16.0-update-sale_recurring_payment branch from a91dd4a to da7c151 Compare August 21, 2024 10:49
@tarteo tarteo merged commit 2f204d2 into 16.0 Aug 21, 2024
1 of 3 checks passed
@tarteo tarteo deleted the 16.0-update-sale_recurring_payment branch August 21, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarteo tarteo tarteo requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ByteMeAsap @tarteo