Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[17.0][ADD]: account_credit_control_attach_invoice #423

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

victorvermot
Copy link

@victorvermot victorvermot commented Feb 4, 2025

We want to be able to attach invoices and other reports when printing credit control reports.
This module adds a setting that allows the user to chose which report is attached to the pdf

This work is based on a module developed by @santostelmo OCA/l10n-switzerland#711

@victorvermot victorvermot force-pushed the add_account_credit_control_attach_invoice branch 3 times, most recently from 0bd6ed7 to 4ad8862 Compare February 5, 2025 15:43
@victorvermot victorvermot marked this pull request as ready for review February 5, 2025 15:51
@victorvermot victorvermot force-pushed the add_account_credit_control_attach_invoice branch 2 times, most recently from 468db58 to 4b819e1 Compare February 5, 2025 16:00
Copy link
Contributor

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But I have a question and there is no unit tests

@@ -0,0 +1,2 @@
- Telmo Santos \<<[email protected]>\>
- Victor Vermot-Petit-Outhenin \<<[email protected]>\>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Victor Vermot-Petit-Outhenin \<<victorvermot@gmail.com>\>
- Victor Vermot-Petit-Outhenin \<<victor.vermot@camptocamp.com>\>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hum, that's fine with me if he uses his personal email.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well it's a detail, but work is done at the service of camptocamp

@victorvermot victorvermot force-pushed the add_account_credit_control_attach_invoice branch 2 times, most recently from 6edbb03 to 7e16a9e Compare February 11, 2025 09:36
@victorvermot victorvermot force-pushed the add_account_credit_control_attach_invoice branch from 7e16a9e to 5cdddda Compare February 11, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants