Skip to content

feat(dms): add file content search to community version [Silvertouch …#366

Closed
dakshesh-sttl wants to merge 1 commit intoOCA:16.0from
dakshesh-sttl:16.0
Closed

feat(dms): add file content search to community version [Silvertouch …#366
dakshesh-sttl wants to merge 1 commit intoOCA:16.0from
dakshesh-sttl:16.0

Conversation

@dakshesh-sttl
Copy link

…Technologies]

Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the PR is wrong, remember the guidelines, it should be: [16.0][IMP] dms: Add indexed content to files (or similar)

Considering base does with ir.attachment (https://github.com/odoo/odoo/blob/14.0/odoo/addons/base/models/ir_attachment.py#L355) and the attachment_indexation module I think the following should be done (if possible):

  • The index_content field should be a compute store and set the value in a “similar” way as it is done in base.
  • Create a module called dms_indexation that depends on attachment_indexation and dms and “extend” the dms method to contemplate more formats.

What do you think @pedrobaeza ?

I think that creating PRs for all branches is not a good technique, because if you have to change something you will have to change it in all of them, the right thing to do is to create one and when it is merged take it to higher versions (one by one).

@pedrobaeza
Copy link
Member

Yes, please put this on a separate module for being optional.

@github-actions
Copy link

github-actions bot commented Feb 2, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 2, 2025
@github-actions github-actions bot closed this Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants