feat(dms): add file content search to community version [Silvertouch …#366
feat(dms): add file content search to community version [Silvertouch …#366dakshesh-sttl wants to merge 1 commit intoOCA:16.0from
Conversation
victoralmau
left a comment
There was a problem hiding this comment.
The name of the PR is wrong, remember the guidelines, it should be: [16.0][IMP] dms: Add indexed content to files (or similar)
Considering base does with ir.attachment (https://github.com/odoo/odoo/blob/14.0/odoo/addons/base/models/ir_attachment.py#L355) and the attachment_indexation module I think the following should be done (if possible):
- The
index_contentfield should be a compute store and set the value in a “similar” way as it is done in base. - Create a module called
dms_indexationthat depends onattachment_indexationanddmsand “extend” the dms method to contemplate more formats.
What do you think @pedrobaeza ?
I think that creating PRs for all branches is not a good technique, because if you have to change something you will have to change it in all of them, the right thing to do is to create one and when it is merged take it to higher versions (one by one).
|
Yes, please put this on a separate module for being optional. |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
…Technologies]